[REF] Separate export form classes out & simplify task handling #18589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Sep 25, 2020
This variable is only used at the tpl layer in export - there is a separate PR to change that usage to something more meaningful civicrm#18589 Other than that all this task assignment appears to be just cruft It's likely that it precedes other ways of setting the page title
This was referenced Sep 25, 2020
|
@monishdeb could you review this? Thx |
It turns out all this taskName assigning is just to compare it with 'Export Contacts' in the tpl This makes it more direct
af5b884 to
f95d7a0
Compare
|
@monishdeb did you get a chance to look at this? |
|
Jenkin test this please |
|
Sorry for delay. Tested export action with 'select fields' option on all desired entities like contact, activity, event, contribution, grant etc. without any issue. Merge action is rightfully disabled on the appropriate export entity page like activity, contribution etc. Overall, good initiative towards making entity specific export classes, towards adding more clarity. I am happy with the PR, merging now. |
|
thanks @monishdeb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This separates out the rest of the export classes to be separate classes extending the parent. 2 functions are switched to overrride
Before
Lots of wrangling to get entity specific information. Task title involves lots of noise to do one boolean check
After
Entity specific information is on the class (partially - in progress)
Technical Details
Comments
@colemanw