Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2066 [WIP] Add support for calling (some) contribution actions in stand alone mode #18592

Closed
wants to merge 3 commits into from

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 25, 2020

Overview

Preliminary work on exposing core search actions outside the context of search. The intent is they can be called from search creator but in the interests of exploration I have exposed them via search results

Before

Awkward to send a receipt - need to go via search - unavailable from search creator extension

After

Ground work done to access some contribute tasks via url - ie

civicrm/civicrm/contribute/task?reset=1&id=98,99,100&task=delete
civicrm/civicrm/contribute/task?reset=1&id=98,99,100&task=invoice

Some are exposed

Screen Shot 2020-09-25 at 7 24 40 PM

Screen Shot 2020-09-25 at 7 24 49 PM

Technical Details

This is exploratory - my main focus is the cleanup to support using tasks in standalone mode. It's distinctly glitchy at the moment & the appropriateness of exposing specific actions

Comments

I think pre-existing enotices prevents the pop-up closing for send receipt

Note - this doesn't have to stay open - I'll probably spin off some parts - currently cleanup PR #18589

@civibot civibot bot added the master label Sep 25, 2020
@civibot
Copy link

civibot bot commented Sep 25, 2020

(Standard links)

@eileenmcnaughton eileenmcnaughton changed the title [WIP] Add support for calling (some) contributions in stand alone mode dev/core#2066 [WIP] Add support for calling (some) contributions in stand alone mode Sep 25, 2020
@eileenmcnaughton eileenmcnaughton force-pushed the cont_action branch 4 times, most recently from e977c92 to 99772f3 Compare September 25, 2020 10:18
@eileenmcnaughton
Copy link
Contributor Author

@colemanw @monishdeb @JoeMurray FYI - I got 'somewhere' with this - although I will probably close this & figure out how to break it down

@JoeMurray
Copy link
Contributor

Looks like good progress. Please feel free to ask @monishdeb to do review/QA of something in this area, or to do some coding once you have a direction that you're comfortable with.

@mattwire mattwire changed the title dev/core#2066 [WIP] Add support for calling (some) contributions in stand alone mode dev/core#2066 [WIP] Add support for calling (some) contribution actions in stand alone mode Sep 25, 2020
@eileenmcnaughton
Copy link
Contributor Author

@JoeMurray thanks - there are some preliminary PRs to this...notably #18589 at the moment

It turns out all this taskName assigning is just to compare it with 'Export Contacts' in the tpl

This makes it more direct
@eileenmcnaughton
Copy link
Contributor Author

I'm gonna close this since it's not in a reviewable state right now but once the related cleanup prs are merged I'll open a new Pr for the parts. It might be good to do a big push on this for 5.32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants