[REF] Remove unused taskName variable #18590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is only used at the tpl layer in export - there is a separate PR to change that usage to something more meaningful civicrm#18589 Other than that all this task assignment appears to be just cruft It's likely that it precedes other ways of setting the page title
|
(Standard links)
|
|
@monishdeb is this one you could look at - cleanup towards search actions |
|
The only place I see this is in Export/Form/Select.tpl where it checks for a specific value that is none of these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This variable is only used at the tpl layer in export - there is a separate PR
to change that usage to something more meaningful
#18589
Other than that all this task assignment appears to be just cruft
Before
After
Task titles still visible on page...
Only export still refers
Technical Details
It's likely that it precedes other ways of setting the page title
Comments