Remove unused variables from repeatTransaction #18209
Conversation
|
(Standard links)
|
| @@ -2613,7 +2613,7 @@ public static function contributionCount($contactId, $includeSoftCredit = TRUE) | |||
| * @return bool|array | |||
| * @throws CiviCRM_API3_Exception | |||
| */ | |||
| protected static function repeatTransaction(&$contribution, &$input, $contributionParams) { | |||
| protected static function repeatTransaction(&$contribution, $input, $contributionParams) { | |||
There was a problem hiding this comment.
Nothing from $input is used after repeatTransaction
| @@ -4498,7 +4498,7 @@ public static function completeOrder($input, &$ids, $objects, $isPostPaymentCrea | |||
| ], array_intersect_key($input, array_fill_keys($inputContributionWhiteList, 1) | |||
| )); | |||
|
|
|||
| $contributionParams['payment_processor'] = $input['payment_processor'] = $paymentProcessorId; | |||
| $contributionParams['payment_processor'] = $paymentProcessorId; | |||
There was a problem hiding this comment.
$input['payment_processor'] is not used.
|
I don't think we can realistically test removing things that we think do nothing (ok-without-test). I took a quite look at the first line & $input is passed to another function after this so I would need to dig more thoroughly (ie I can't merge this in my triage pass) |
|
@eileenmcnaughton Re. Once repeatTransaction returns you'll see similar, only amount, component, is_email_receipt and trxn_id are read, all of which are set before the call to repeatTransaction. |
|
OK - I've been through this a bit more carefully & I agree that nothing set in repeatTransaction is ever used again. This is a good cleanup because the time it took us to figure this out means it doesn't have to be figured out in the context of another change later. Merging |
Overview
More simplification
Before
Unused variables.
After
Not
Technical Details
See inline comments
Comments
@eileenmcnaughton