Merge pull request #18209 from mattwire/repeattransaction_cleanup

Remove unused variables from repeatTransaction
civicrm · Aug 21, 2020 · 72a028a · 72a028a
2 parents 1b5bcf0 + 34dc58e
commit 72a028a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php
@@ -2613,7 +2613,7 @@ public static function contributionCount($contactId, $includeSoftCredit = TRUE)
    * @return bool|array
    * @throws CiviCRM_API3_Exception
    */
-  protected static function repeatTransaction(&$contribution, &$input, $contributionParams) {
+  protected static function repeatTransaction(&$contribution, $input, $contributionParams) {
     if (!empty($contribution->id)) {
       return FALSE;
     }
@@ -4498,7 +4498,7 @@ public static function completeOrder($input, &$ids, $objects, $isPostPaymentCrea
     ], array_intersect_key($input, array_fill_keys($inputContributionWhiteList, 1)
     ));
 
-    $contributionParams['payment_processor'] = $input['payment_processor'] = $paymentProcessorId;
+    $contributionParams['payment_processor'] = $paymentProcessorId;
 
     // If paymentProcessor is not set then the payment_instrument_id would not be correct.
     // not clear when or if this would occur if you encounter this please fix here & add a unit test.