Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variables from repeatTransaction #18209

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Remove unused variables from repeatTransaction #18209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CRM/Contribute/BAO/Contribution.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2613,7 +2613,7 @@ public static function contributionCount($contactId, $includeSoftCredit = TRUE)
* @return bool|array
* @throws CiviCRM_API3_Exception
*/
protected static function repeatTransaction(&$contribution, &$input, $contributionParams) {
protected static function repeatTransaction(&$contribution, $input, $contributionParams) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing from $input is used after repeatTransaction

if (!empty($contribution->id)) {
return FALSE;
}
Expand Down Expand Up @@ -4498,7 +4498,7 @@ public static function completeOrder($input, &$ids, $objects, $isPostPaymentCrea
], array_intersect_key($input, array_fill_keys($inputContributionWhiteList, 1)
));

$contributionParams['payment_processor'] = $input['payment_processor'] = $paymentProcessorId;
$contributionParams['payment_processor'] = $paymentProcessorId;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$input['payment_processor'] is not used.


// If paymentProcessor is not set then the payment_instrument_id would not be correct.
// not clear when or if this would occur if you encounter this please fix here & add a unit test.
Expand Down