Migrate KAM smartmenus to core #13582
Conversation
|
(Standard links)
|
21c55c8 to
9d7c842
Compare
|
The KAM extension has gone through a month's-long period of review & refinement. At this point it's been tested on all the CMSs with a wide variety of settings. I believe it's time to merge it into master so it will be part of next month's RC. FYI @JoeMurray @aydun @monishdeb @mattwire @vingle @christianwach @themak1985 @laryn @artfulrobot |
|
@civicrm-builder retest this please |
|
@colemanw this needs a rebasing now |
|
@civicrm-builder retest this please |
|
Awesome. Will start with D8 and D7 and its accessibility behavior as listed in https://lab.civicrm.org/dev/accessibility/issues/1. I also like to invite others to review this patch, as this is a big improvement towards Civi Menu and patch be should be scrutinized on all aspects. @colemanw should I mention this PR in dev channel? |
|
@colemanw isn't the patch should include the bower.json commit to include the smartmenu library |
|
@monishdeb - very strange that when I typed |
|
Jenkins re test this please |
|
I think this PR is a bit daunting for one person to want the responsibility of being the one to press the Merge button. But it has received extensive testing as an extension. |
f1c892c to
f766a46
Compare
|
@civicrm-builder retest this please. @eileenmcnaughton what additional work is needed? FYI I have already rebased in the recent bug fixes from the KAM extension. |
|
@colemanw my understanding is that this will be a big problem if we merge this before updating shoreditch - also I would err towards merging straight after the rc is cut to give it max review time |
|
I'm ok with bumping this back one more release & merging next week. But I'm less concerned about Shoreditch as there is already a PR in the works on that side, and this would just be one of several breaking changes to core that have been released lately (another being civicrm/org.civicrm.shoreditch#356) |
|
@colemanw ah that one too huh? What is the status with the shoreditch sprint - I feel like a goal of that sprint should be that this is tested with shoreditch & given the 'merge-ready' flag |
Kind-of. As @colemanw says there are already a few breaking changes in core as far as the shoreditch extension is concerned and outstanding PRs for the extension. The KAM menu actually works well with shoreditch already (I'm using it on all my production sites) and I don't think anything in the shoreditch extension should be seen as a blocker to this PR being merged - in fact I think this PR needs merging before changes are merged in the shoreditch extension - so the minversion on shoreditch can be bumped to the release containing this PR and we can rip out various bits that support old versions of Civi. |
|
@mattwire OK - that's a reasonable case - ie a bunch of work is being done on shoreditch - now-ish? so it would be better if this was merged for that to be done against.... Do you think we should just merge this now & deal with anything that comes out of it? |
I would say so, it's had pretty good user testing as an extension. I'm sure there will be one or two issues that pop up but we're not going to find them until it's merged. And, we've just had a security release so there are likely to be less forced upgrades to the next version (ie. more time for issues to be found). |
|
@mattwire OK - I'll take your advice on it - I guess one thing is that this will be well tested as EVERYONE uses the menu - so devs should be giving it a good bash over the next 6 weeks |
Overview
Ports the KAM extension into CiviCRM core.
Before
Extension required to get the new smartmenus-based menubar.
After
New smartmenus-based menubar included with core. KAM and Slicknav extensions marked obsolete.