Move l10n.js to coreResourcesList #13612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows core resources to be added to the list AFTER l10n variables have been initialized. This is needed by crm.menubar.js. Another upshot of this change is that extensions will be able to add items to the list as fully-formed urls.
|
(Standard links)
|
|
@eileenmcnaughton care to trade review on this one? |
|
@colemanw OK |
|
I've made sense of the changes in here & they seem sensible & a code improvement - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change allows core resources to be added to the list AFTER l10n variables have been initialized. This is needed by crm.menubar.js.
An upshot of this change is that hooks will be able to interact with it.
Another upshot of this change is that extensions will be able to add items to the list as fully-formed urls.
Before
l10n.js dynamic script was added outside of the coreResourcesList.
After
l10n.js dynamic script added within coreResourcesList.
Comments
This is a small chunk bitten off the mega #13582 to facilitate review.