Remove all menubar css and js

[colemanw]

The soon-to-be-in-core KAM extension natively implements basically all the things that Shoreditch was adding onto the menubar - lighter color scheme, robust markup, larger size, etc.

I'd recommend we remove all menubar-related css and JS from Shoreditch and start from scratch if there are any remaining tweaks to be done.

[monishdeb]

I agree. I faced an issue with q-search icon which is specific to shoreditch custom css changes, after KAM extension is installed:

I fixed it by removing the css styling for q-search, see here

After fix:

[AkA84]

@colemanw do you know, approximately, when the KAM extension will be merged into core? It would be best to remove anything menu-related (or to heavily amend it at least) only after the extension has become part of core

[colemanw]

@AkA84 probably next month, which would set the version at 5.11.
But cleaning up the css/js in this extension and testing it with KAM could happen now. It could even be released now, with KAM declared as a dependency. Once KAM is merged with core that dependency would be automatically resolved, based on some work I'm doing right now on the extension management system.

[colemanw]

@jamienovick @AkA84 The inclusion of KAM in core is looming closer with aydun/uk.squiffle.kam#16 wrapping up. I strongly suggest you get someone to test out that extension with Shoreditch in the next week or so in case there is something critical missing from KAM you'd like to see. Pushing changes into that extension is fairly easy while it remains an extension...

[AkA84]

@colemanw thanks for the heads-up! The ~1w window though is a bit unfortunate given the proximity to the holidays, so I'm not sure that all the necessary (extensive testing, tweaking of the theme to properly add its own look-and-feel to the menu, etc) can be done before I'm back. For consideration: this could be attacked as part of the community efforts (see https://lab.civicrm.org/extensions/shoreditch/issues/1)

(cc @jamienovick )

[colemanw]

@AkA84 @jamienovick the holidays slowed me down as well so this is getting pushed to 5.12. However several extensions including CiviTutorial and RecentMenu now declare KAM as a dependency (when KAM is merged into core that dependency will automatically be resolved). I think the time is now for ShoreDitch to do the same.

[colemanw]

civicrm/civicrm-core#13582 has been opened, targeting 5.12 for inclusion in core.

[eileenmcnaughton]

I just had multiple bugs reported when we enabled KAM that turned out to be related to this.

[eileenmcnaughton]

I have the 5.13 rc on our staging & locally & it just started to look really bad - I'm gonna try the patch above

[twomice]

FYI, the display issue mentioned by @eileenmcnaughton above is resolved by removing the background-color rule for #civicrm-menu (see here)

[eileenmcnaughton]

Cool - I've been adding css through a hook to override shoreditch where it makes me sad - maybe I should include that

[themak1985]

@twomice how are you implementing this with alpha31?

[twomice]

@themak1985 I haven't had to face that yet.

[jamienovick]

Closing as fixed in latest version