Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GENESIS] Make camino part of genesis fully optional #307

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

evlekht
Copy link
Member

@evlekht evlekht commented Feb 27, 2024

Why this should be merged

In genesis json we have camino field which contains camino-specific data. Initial idea was that we'll keep all avax logic and introduce our own in addition to that, so both camino and avax tests can work with existing code. But there are still still some inconsistency in that.

If we'll try to run node with custom genesis json, which doesn't have camino field at all, like normal avax genesis, genesis parsing will fail cause of invalid initial admin address. This PR solves it by making whole camino field logic optional.

How this works

Make camino field pointer, so default value will be nil. Check for not nil before doing something with this field.

How this was tested

Existing unit-tests and e2e tests.
Manual start of local node with custom genesis without camino field.

@knikos knikos self-requested a review February 27, 2024 13:01
@evlekht evlekht marked this pull request as ready for review February 27, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants