[GENESIS] Make camino part of genesis fully optional #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82212ae to
139c770
Compare
139c770 to
5f6af3f
Compare
mo-c4t
previously approved these changes
Aug 5, 2024
Noctunus
previously approved these changes
Aug 5, 2024
The base branch was changed.
5f6af3f to
95f6811
Compare
mo-c4t
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
In genesis json we have
caminofield which contains camino-specific data. Initial idea was that we'll keep all avax logic and introduce our own in addition to that, so both camino and avax tests can work with existing code. But there are still still some inconsistency in that.If we'll try to run node with custom genesis json, which doesn't have
caminofield at all, like normal avax genesis, genesis parsing will fail cause of invalid initial admin address. This PR solves it by making wholecaminofield logic optional.How this works
Make
caminofield pointer, so default value will be nil. Check for not nil before doing something with this field.How this was tested
Existing unit-tests and e2e tests.
Manual start of local node with custom genesis without camino field.
Additional references
Original PR based on cortina-7 dev
#307