[PVM] replace nil-signers Sign with Initialize, make syncGenesis private #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74cae09 to
3357e14
Compare
mo-c4t
previously approved these changes
Aug 5, 2024
Noctunus
previously approved these changes
Aug 5, 2024
3357e14 to
f6a97d9
Compare
The base branch was changed.
mo-c4t
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
CaminoState.SyncGenesis is only called from the same package, exactly as intended, so there is no need to export this method.
txs.NewSigned calls txs.Sign. If nil signers arg is passed, than Sign method results only in setting signedTx bytes and unsignedTx bytes to tx fields, no actual signing is performed, though it still does things like calculating unsigned tx hash for signing purposes. There is no need in it. Replace all those calls with tx.Initialize which does same bytes initialization (as done in some of avax methods).
How this works
CaminoState.SyncGenesis -> CaminoState.syncGenesis
txs.NewSigned(txs.Codec, nil) -> txs.Initialize(txs.Codec)
How this was tested
Existing unit and e2e tests.
Additional references
Original PR based on cortina-15 dev
#345