Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picking incompatible changes to web_adapter v1 #2362

Merged
merged 9 commits into from
Jan 24, 2025

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Jan 23, 2025

Further implementation of #2281

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

AlexV525 and others added 8 commits January 23, 2025 19:35
https://pub.dev/packages/melos/versions/6.3.0/changelog

```console
scripts/melos_packages.dart:47:23: Error: The getter 'pubSpec' isn't defined for the class 'Package'.
 - 'Package' is from 'package:melos/src/package.dart' ('../../../.pub-cache/hosted/pub.dev/melos-6.3.1/lib/src/package.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'pubSpec'.
      .where((e) => e.pubSpec.environment!.sdkConstraint!.allows(current));
                      ^^^^^^^
```

(cherry picked from commit ffa1cc6)
Add the ability to change the `FileMode` of the download without altering the default value, which is `FileMode.write`, to make resuming downloads easier to implement by introducing `FileAccessMode` and mapping it to `FileMode` in `DioForNative`.

---

Signed-off-by: shehab mohame <shehabman@gmail.com>
Co-authored-by: Alex Li <github@alexv525.com>

(cherry picked from commit 779ccf0)
NeverSSL no longer supports H2 headers upgrade without TLS. All
alternatives I've searched are not supported:
- http://www.gstatic.com/generate_204
- http://http.badssl.com/
- http://flutter.dev/

Surprisingly, http://flutter-io.cn/ supports all functionality. 😮

---------

Signed-off-by: Luke Cheng <2258420+chenglu@users.noreply.github.com>
Co-authored-by: Luke Cheng <2258420+chenglu@users.noreply.github.com>
(cherry picked from commit 0f1c46e)
@AlexV525 AlexV525 marked this pull request as ready for review January 23, 2025 13:31
@AlexV525 AlexV525 requested a review from a team as a code owner January 23, 2025 13:31
Copy link
Contributor

Code Coverage Report: Only Changed Files listed

Package Coverage
Overall Coverage 🟢 82.3%

Minimum allowed coverage is 0%, this run produced 82.3%

@AlexV525 AlexV525 merged commit ed93e58 into feat/web/v1-adapter Jan 24, 2025
3 checks passed
AlexV525 added a commit that referenced this pull request Jan 24, 2025
@AlexV525 AlexV525 deleted the feat/web/v1-adapter-patch branch January 24, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants