Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷 Check bootstrappable package as a prehook of melos and log checked packages #2363

Merged
merged 1 commit into from
Jan 24, 2025
Merged

👷 Check bootstrappable package as a prehook of melos and log checked packages #2363

merged 1 commit into from
Jan 24, 2025

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Jan 24, 2025 •
edited
Loading

Picked and updated from #2362

image image

@AlexV525 AlexV525 added the infra label Jan 24, 2025
@AlexV525 AlexV525 self-assigned this Jan 24, 2025
@AlexV525 AlexV525 marked this pull request as ready for review January 24, 2025 06:08
@AlexV525 AlexV525 requested a review from a team as a code owner January 24, 2025 06:08
@AlexV525 AlexV525 merged commit 83c57de into main Jan 24, 2025
2 of 3 checks passed
@AlexV525 AlexV525 deleted the ci/melos-script branch January 24, 2025 06:26
@kuhnroyal
Copy link
Member

Just saw this an noticed that it sadly does not work for the bootstrapping itself.

@AlexV525
Copy link
Member Author

Just saw this an noticed that it sadly does not work for the bootstrapping itself.

Could you elaborate? I didn't understand the sentence. 😢

@kuhnroyal
Copy link
Member

Just saw this an noticed that it sadly does not work for the bootstrapping itself.

Could you elaborate? I didn't understand the sentence. 😢

Sorry for being unclear :)
The script correctly marks the packages but it does not limit the packages being bootstrapped to the same set. As far as I can tell all packages are being bootstrapped. This still only works by using the ugly marker files.
Not much we can do atm, this was more of a mental note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlexV525 AlexV525

Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexV525 @kuhnroyal