Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Fix melos package script #2354

Merged
merged 2 commits into from
Jan 13, 2025
Merged

💚 Fix melos package script #2354

merged 2 commits into from
Jan 13, 2025

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Jan 12, 2025

https://pub.dev/packages/melos/versions/6.3.0/changelog

scripts/melos_packages.dart:47:23: Error: The getter 'pubSpec' isn't defined for the class 'Package'.
 - 'Package' is from 'package:melos/src/package.dart' ('../../../.pub-cache/hosted/pub.dev/melos-6.3.1/lib/src/package.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'pubSpec'.
      .where((e) => e.pubSpec.environment!.sdkConstraint!.allows(current));
                      ^^^^^^^

@AlexV525 AlexV525 requested a review from a team as a code owner January 12, 2025 01:01
Copy link
Contributor

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 84.71% 🟢 84.71% ⚪ 0%

Minimum allowed coverage is 0%, this run produced 84.71%

Copy link
Contributor

@CaiJingLong CaiJingLong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexV525 AlexV525 merged commit ffa1cc6 into main Jan 13, 2025
3 checks passed
@AlexV525 AlexV525 deleted the fix/ci branch January 13, 2025 02:11
AlexV525 added a commit that referenced this pull request Jan 23, 2025
https://pub.dev/packages/melos/versions/6.3.0/changelog

```console
scripts/melos_packages.dart:47:23: Error: The getter 'pubSpec' isn't defined for the class 'Package'.
 - 'Package' is from 'package:melos/src/package.dart' ('../../../.pub-cache/hosted/pub.dev/melos-6.3.1/lib/src/package.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'pubSpec'.
      .where((e) => e.pubSpec.environment!.sdkConstraint!.allows(current));
                      ^^^^^^^
```

(cherry picked from commit ffa1cc6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants