Fix App deprecation check mechanism #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrossy
reviewed
Oct 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #1358 +/- ##
==========================================
+ Coverage 73.78% 74.29% +0.51%
==========================================
Files 279 278 -1
Lines 7606 7540 -66
Branches 657 660 +3
==========================================
- Hits 5612 5602 -10
+ Misses 1881 1825 -56
Partials 113 113
Continue to review full report at Codecov.
|
jmrossy
reviewed
Oct 20, 2019
…o-monorepo into rohit-dua/app-version-check
Added the Testing information in the description: TestingThe deprecation system was tested on the device by:
In both the cases the deprecation screen was showed at app start. |
jmrossy
reviewed
Oct 22, 2019
jmrossy
approved these changes
Oct 23, 2019
…o-monorepo into rohit-dua/app-version-check
martinvol
reviewed
Oct 23, 2019
…o-monorepo into rohit-dua/app-version-check
martinvol
reviewed
Nov 11, 2019
aaronmgdr
added a commit
that referenced
this pull request
Nov 14, 2019
* master: (56 commits) Adjust e2e transfer and governance tests to match new fee distribution and eliminate ProposerFraction (#1585) [Wallet] Add more local currencies (#1698) Switch to correct cluster when fauceting (#1687) [Wallet] Use the country of the phone number for determining the default local currency (#1684) [Wallet] Limit QR code scanner to 1 code per second (#1676) Update Dark backgrounds text color (#1677) Remove integration sync test Minor attestation service fixes (#1680) [wallet] Fixed Native phone picker Use native API instead (#1669) Fix token addresses for notification service (#1674) Add golang to setup docs [wallet] Hide invite education copy after invite was redeemed (#1670) [Wallet] Add spinner, timer, and tip text to Verification input screen (#1656) [Wallet] Fix app deprecation check mechanism (#1358) Point end-to-end governance test back to master (#1665) Add EpochRewards smart contract to calculate epoch rewards and payments (#1558) Optimized Attestation view calls and removal of the reveal TX (#1578) Support claim signatures and support Keybase claims (#1575) [Wallet] Add timestamp to top banner messages (#1657) Export geth metrics on VM testnet (#1351) ... # Conflicts: # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The app deprecation check mechanism was not working as it required firebase login with web3 account. This requirement is not required for the version check.
Atm we need to register every single version and mark it deprecated in the firebase DB. Now a minimum version in firebase db should do the task
Testing
The deprecation system was tested on the device by:
versions > 1 > 5 > 0 > deprecated > truewas used.minVersionflag to versions and providing it a higher value than the current versionIn both the cases the deprecation screen was showed at app start.
Related issues
Backwards compatibility
It is backwards compatible.