Fix App deprecation check mechanism

packages/mobile/src/app/saga.ts

@@ -6,7 +6,6 @@ import { PincodeType } from 'src/account/reducer'
 import { setLanguage } from 'src/app/actions'
 import { handleDappkitDeepLink } from 'src/dappkit/dappkit'
 import { getVersionInfo } from 'src/firebase/firebase'
-import { waitForFirebaseAuth } from 'src/firebase/saga'
 import { NavActions, navigate } from 'src/navigator/NavigationService'
 import { Screens, Stacks } from 'src/navigator/Screens'
 import { PersistedRootState } from 'src/redux/reducers'
@@ -49,7 +48,6 @@ const mapStateToProps = (state: PersistedRootState): PersistedStateProps | null
 
 export function* checkAppDeprecation() {
   yield call(waitForRehydrate)
-  yield call(waitForFirebaseAuth)
   const versionInfo = yield getVersionInfo(DeviceInfo.getVersion())
   Logger.info(TAG, 'Version Info', JSON.stringify(versionInfo))
   if (versionInfo && versionInfo.deprecated) {

packages/mobile/src/firebase/db-rules.json

@@ -10,10 +10,8 @@
       }
     },
     "versions": {
-      "$verion_string": {
-        ".read": true,
-        ".write": false
-      }
+      ".read": true,
+      ".write": false
     },
     "lastBlockNotified": {
       ".read": false,

packages/mobile/src/firebase/firebase.test.ts

@@ -0,0 +1,26 @@
+import { getNestedValue, isDeprecatedVersion } from 'src/firebase/firebase'
+import { mockNestedObject } from 'test/values'
+
+describe('Firebase version check', () => {
+  it('Correctly check if version is deprecated', () => {
+    let isDeprecated: boolean = isDeprecatedVersion('1.5.0', '1.4.0')
+    expect(isDeprecated).toBe(false)
+    isDeprecated = isDeprecatedVersion('1.4.0', '1.5.0')
+    expect(isDeprecated).toBe(true)
+    isDeprecated = isDeprecatedVersion('1.4.0', '1.4.0')
+    expect(isDeprecated).toBe(false)
+    isDeprecated = isDeprecatedVersion('1.4.0', '1.4.0.1')
+    expect(isDeprecated).toBe(true)
+  })
+})
+
+describe('Nested Object', () => {
+  it('Correct get nested value from an object', () => {
+    let value = getNestedValue(mockNestedObject, ['1', '2', '3'])
+    expect(value).toBe(true)
+    value = getNestedValue(mockNestedObject, ['1', '2', '4'])
+    expect(value).toBe(false)
+    value = getNestedValue(mockNestedObject, ['1', '2', '4', '5'])
+    expect(value).toBeUndefined()
+  })
+})

packages/mobile/src/firebase/firebase.ts

@@ -114,13 +114,63 @@ export const writePaymentRequest = (paymentInfo: PaymentRequest) => async () =>
   }
 }
 
+export function isDeprecatedVersion(version: string, minVersion: string): boolean {
+  const minVersionArray = minVersion.split('.')
+  const versionArray = version.split('.')
+  const minVersionLength = Math.min(minVersionArray.length, version.length)
+  for (let i = 0; i < minVersionLength; i++) {
+    if (minVersionArray[i] > versionArray[i]) {
+      return true
+    } else if (minVersionArray[i] < versionArray[i]) {
+      return false
+    }
+  }
+  if (minVersionArray.length > versionArray.length) {
+    return true
+  }
+  return false
+}
+
+export function getNestedValue(dict: object, keyList: string[]): any {
+  let nestedDict: any = dict
+  for (const key of keyList) {
+    if (typeof nestedDict !== 'object' || nestedDict[key] === undefined) {
+      return undefined
+    }
+    nestedDict = nestedDict[key]
+  }
+  return nestedDict
+}
+
+/*
+Get the Version deprecation information.
+@param version: string The version to check for deprecation
+@return: object { version: <VERSION>, deprecated: <BOOLEAN> }
+Firebase DB Format: 
+  (Backward Compatibility) Add child to versions category in the format versions>1>5>0>{deprecated: true}
+  (New) Add minVersion child to versions category with a string of the mininum version as string
+*/
 export async function getVersionInfo(version: string) {
-  const versionFSPath = version.split('.').join('/')
+  let deprecated: boolean = false
   Logger.info(TAG, `Checking version info ${version}`)
-  return (await firebase
+  const versionsInfo = (await firebase
     .database()
-    .ref(`versions/${versionFSPath}`)
+    .ref('versions')
     .once('value')).val()
+  if (!versionsInfo) {
+    return { deprecated, version }
+  }
+  // backward compatible check
+  const currentVersionInfo = getNestedValue(versionsInfo, version.split('.'))
+  if (currentVersionInfo && currentVersionInfo.deprecated !== undefined) {
+    return currentVersionInfo
+  }
+  if (!versionsInfo.minVersion) {
+    return { version, deprecated }
+  }
+  const minVersion: string = versionsInfo.minVersion
+  deprecated = isDeprecatedVersion(version, minVersion)
+  return { version, deprecated }
 }
 
 export async function setUserLanguage(address: string, language: string) {

packages/mobile/src/firebase/saga.ts

@@ -40,7 +40,6 @@ export function* waitForFirebaseAuth() {
 
 function* initializeFirebase() {
   const address = yield call(getAccount)
-
   if (!FIREBASE_ENABLED) {
     Logger.info(TAG, 'Firebase disabled')
     yield put(showError(ErrorMessages.FIREBASE_DISABLED))

packages/mobile/test/values.ts

@@ -34,6 +34,7 @@ export const mockE164Number2 = '+12095559790'
 export const mockDisplayNumber2 = '(209) 555-9790'
 export const mockComment = 'Rent request for June, it is already late!!!'
 export const mockCountryCode = '+1'
+export const mockNestedObject = { '1': { '2': { '3': true, '4': false } } }
 
 export const mockQrCodeData = `{"address":"${mockAccount}","e164PhoneNumber":"${mockE164Number}","displayName":"${mockName}"}`