Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App deprecation mechanism seems broken #1235

Closed
jmrossy opened this issue Oct 7, 2019 · 0 comments · Fixed by #1358
Closed

App deprecation mechanism seems broken #1235

jmrossy opened this issue Oct 7, 2019 · 0 comments · Fixed by #1358
Assignees
@jmrossy
Labels
bug Something isn't working Priority: P3 Minor triaged label for issues that have been assigned a priority wallet

Comments

@jmrossy
Copy link
Contributor

jmrossy commented Oct 7, 2019

Expected Behavior

The phone shows the deprecation screen on startup when its version is out of date.
Also, bonus points for making the version checking smarter. Atm we need to register every single version and mark it deprecated in the firebase DB. it should instead just have a single minimum version

Current Behavior

Volpe's phone didn't show the deprecation notice.
@jmrossy jmrossy changed the title App deprecation mechanism may be broken App deprecation mechanism seems broken Oct 7, 2019
@jmrossy jmrossy added wallet bug Something isn't working labels Oct 7, 2019
@nityas nityas added applications Priority: P1 Critical triaged label for issues that have been assigned a priority labels Oct 14, 2019
@rohit-dua rohit-dua mentioned this issue Oct 16, 2019
Merged
@jmrossy jmrossy self-assigned this Oct 30, 2019
@jmrossy jmrossy added Priority: P3 Minor and removed Priority: P1 Critical labels Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmrossy jmrossy

Labels
bug Something isn't working Priority: P3 Minor triaged label for issues that have been assigned a priority wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix App deprecation check mechanism celo-org/celo-monorepo
3 participants
@jmrossy @nityas @rohit-dua