[Wallet] Update account amount overview style #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
915c785 to
2f5bd21
Compare
jmrossy
reviewed
Oct 18, 2019
cc7409e to
66af9d0
Compare
66af9d0 to
9aeaf6b
Compare
9aeaf6b to
55a963e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1325 +/- ##
==========================================
+ Coverage 67.62% 67.68% +0.05%
==========================================
Files 269 269
Lines 7984 8023 +39
Branches 539 553 +14
==========================================
+ Hits 5399 5430 +31
- Misses 2477 2479 +2
- Partials 108 114 +6
Continue to review full report at Codecov.
|
jmrossy
approved these changes
Oct 23, 2019
tkporter
pushed a commit
that referenced
this pull request
Oct 24, 2019
* Show the local currency amount as primary amount and then Celo dollars * Use local currencies in more screens, including drilldown and exchange
aaronmgdr
added a commit
that referenced
this pull request
Oct 24, 2019
* master: [Wallet] Wallet can switch between hosted and local node (#1419) [Wallet] Prevent error from Avatar when name is missing (#1454) [Wallet] Show splash screen until JS is ready on iOS (#1453) Use new segment api keys used by both iOS and Android (#1452) [Wallet] Don't log all props, which includes i18n (#1445) [Helm] Updated the helm package to deploy the upgraded blockscout version (#1129) Tiny copy change (#1429) [contractkit] SortedOraclesWrapper + tests (#1405) [wallet] Refactor leftover thunk to sagas (#1388) [Wallet] Fix repeated QR code scanning and related navigation issues (#1439) [Wallet] Show the currency values with correct rounding. (#1435) [Wallet] Fix firebase initialization error on iOS after reinstalling the app (#1423) [Wallet] Use exit on iOS since we can't restart like Android (#1424) [Wallet] Update local currency styles and layout (#1325) Reset pincode cache if unlock fails (#1430)
jmrossy
pushed a commit
that referenced
this pull request
Oct 25, 2019
* Add react hooks lint rule to prevent incorrect usage of hooks * Fix local currency regressions from #1325 * Fix crash when changing local currency from the settings due to hooks incorrectly used * Fix dollar exchange rate value shown in local currency in the exchange confirmation card * Fix received gold amounts shown in the local currency * Fix gold received transaction showing up as local currency in the full screen card details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show the local currency amount as primary amount and then Celo dollars.
Tested
Tested in Android device
Other changes
Only additions, no changes.
Related issues
https://user-images.githubusercontent.com/1885747/66928795-3e8d7600-f032-11e9-8937-55f8c9ae9ff0.jpg
https://user-images.githubusercontent.com/1885747/66928797-3f260c80-f032-11e9-8ea4-1ed8a2367665.jpg
https://user-images.githubusercontent.com/1885747/66928798-3f260c80-f032-11e9-9304-612826b8c3dc.jpg
https://user-images.githubusercontent.com/1885747/66928799-3fbea300-f032-11e9-80e7-2f80deea96ae.jpg
https://user-images.githubusercontent.com/1885747/66928800-3fbea300-f032-11e9-8145-92a06e6ab225.jpg
https://user-images.githubusercontent.com/1885747/66928801-3fbea300-f032-11e9-9921-d6f816152189.jpg