[Helm] Updated the helm package to deploy the upgraded blockscout version #1129
Conversation
| @@ -7,8 +7,7 @@ promtosd: | |||
| blockscout: | |||
| image: | |||
| repository: gcr.io/celo-testnet/blockscout | |||
| webTag: web | |||
| indexerTag: indexer | |||
| tag: latest | |||
There was a problem hiding this comment.
Is there a reason you used latest specifically here? We generally use specific tags because docker will often not pull if it already has a tag
There was a problem hiding this comment.
Hi @nambrot,
No any specific reason. Now there is not need for two different images, so I picked latest as default value, but if we are versioning or any other patter I think it is very appropriate.
Codecov Report
@@ Coverage Diff @@
## master #1129 +/- ##
=========================================
Coverage ? 65.87%
=========================================
Files ? 271
Lines ? 8061
Branches ? 559
=========================================
Hits ? 5310
Misses ? 2638
Partials ? 113
Continue to review full report at Codecov.
|
14f6042 to
feb3052
Compare
| @@ -44,6 +44,16 @@ volumes: | |||
| value: {{ .Values.blockscout.jsonrpc_ws_url }} | |||
| - name: DATABASE_URL | |||
| value: postgres://$(DB_USERNAME):$(DB_PASSWORD)@127.0.0.1:5432/{{ .Values.blockscout.db.name }} | |||
| - name: DATABASE_USER | |||
| value: $(DB_USERNAME) | |||
There was a problem hiding this comment.
It's probably easiest to just rename the above variables?
0913d88 to
b52593c
Compare
6499a41 to
0fff638
Compare
4ff425d to
d728b67
Compare
|
@diminator Why did you assign me to this PR? Looks like I already approved it and no changes happened since then |
|
Ok, no worries. If all is good then @jcortejoso can merge |
…re/helm-blockscout-update
* master: [Wallet] Wallet can switch between hosted and local node (#1419) [Wallet] Prevent error from Avatar when name is missing (#1454) [Wallet] Show splash screen until JS is ready on iOS (#1453) Use new segment api keys used by both iOS and Android (#1452) [Wallet] Don't log all props, which includes i18n (#1445) [Helm] Updated the helm package to deploy the upgraded blockscout version (#1129) Tiny copy change (#1429) [contractkit] SortedOraclesWrapper + tests (#1405) [wallet] Refactor leftover thunk to sagas (#1388) [Wallet] Fix repeated QR code scanning and related navigation issues (#1439) [Wallet] Show the currency values with correct rounding. (#1435) [Wallet] Fix firebase initialization error on iOS after reinstalling the app (#1423) [Wallet] Use exit on iOS since we can't restart like Android (#1424) [Wallet] Update local currency styles and layout (#1325) Reset pincode cache if unlock fails (#1430)
Description
Updated the Helm Package to deploy the new version of Blockscout
Tested
No yet tested. Before testing, celo-org/blockscout#8 has to be merged, the new image generated, adapt the image tag to
latestor configure a different docker tag in the helm variables, and then deploy to verify.Related issues
Backwards compatibility
The deployment changes a bit the approach (one unique docker image for the two containers, the indexed and the web, with a different command.