Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users SBAT see switched currency order on home screen #1261

Closed
nityas opened this issue Oct 9, 2019 · 4 comments · Fixed by #1325 or #3032
Closed

Users SBAT see switched currency order on home screen #1261

nityas opened this issue Oct 9, 2019 · 4 comments · Fixed by #1325 or #3032
Assignees
@jeanregisser
Labels
enhancement an improvement to an existing feature Priority: P2 Major triaged label for issues that have been assigned a priority wallet

Comments

@nityas
Copy link
Contributor

nityas commented Oct 9, 2019 •
edited by coreycelo
Loading

Expected Behavior

Figma (includes examples)

Wallet Balance
balance
Changes:

  • "Celo Dollar" text removed
  • Local currency and CUSD swapped in priority

Note: The local currency mockup shows both the currency symbol (€) and acronym (EUR). This is a bit redundant for Euro, but not so with $/MXN.
Some options:

  • Only show acronym
  • Be dynamic based on country (sometimes show symbol, sometimes show both)
  • Always show both

Transaction Feed
feed
Changes:

  • CUSD value is removed
  • Local currency elevated
  • Currency symbol added

Transaction Drilldown
drilldown
Changes:

  • CUSD balance added for Non-USD local currency
  • Text weight for text displaying comment went from Light -> Regular

Current Behavior

  • cUSD on top
  • both currencies in feed
  • no cUSD in drilldown
@coreycelo
Copy link

Added designs.

@nityas Check out note under Wallet Balance above.

@Pedro-vk
Copy link
Contributor

@nityas @jmrossy
The scope of this user story is "Users SBAT see switched currency order on home screen" or all the changes that are in the description?

@Pedro-vk Pedro-vk mentioned this issue Oct 14, 2019
Merged
@nityas
Copy link
Contributor Author

nityas commented Oct 14, 2019

@Pedro-vk the scope is the changes in the description- thanks for clarifying!

@nityas nityas added enhancement an improvement to an existing feature Priority: P2 Major triaged label for issues that have been assigned a priority labels Oct 14, 2019
@nityas nityas reopened this Oct 26, 2019
@nityas
Copy link
Contributor Author

nityas commented Oct 26, 2019

Noticed on the latest build that the order at the top of the home screen is switched. However, the transaction feed and drilldown changes have not been implemented, reopening

@jeanregisser jeanregisser self-assigned this Nov 8, 2019
@jeanregisser jeanregisser mentioned this issue Nov 13, 2019
Merged
@jeanregisser jeanregisser mentioned this issue Jan 15, 2020
Merged
@jmrossy jmrossy mentioned this issue Feb 11, 2020
Closed
@jeanregisser jeanregisser mentioned this issue Mar 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanregisser jeanregisser

Labels
enhancement an improvement to an existing feature Priority: P2 Major triaged label for issues that have been assigned a priority wallet
Projects
None yet
Milestone
No milestone
4 participants
@jeanregisser @Pedro-vk @nityas @coreycelo