-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node | das | libs/header/sync): add total uptime node metrics + totalSampled das metrics + totalSynced sync metrics #1638
Conversation
bddc9f4
to
5a7c590
Compare
Codecov Report
@@ Coverage Diff @@
## main #1638 +/- ##
==========================================
+ Coverage 55.11% 56.24% +1.12%
==========================================
Files 230 232 +2
Lines 15029 15151 +122
==========================================
+ Hits 8283 8521 +238
+ Misses 5862 5725 -137
- Partials 884 905 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
325bf04
to
50c1db3
Compare
179fd50
to
32d965b
Compare
We're successfully retrieving metrics at the moment, however we need to think about calculating the uptime index (from mustafa's proposal) somewhere either in node or in mojtaba's API, since Grafana's min function returns a min over a vector and not a minimum of two values. Here's a screen short of the two values, green being |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just define the const in uptime.go
@mojtaba-esk and I discussed the following comment and concluded to not store any metrics on store at the node side, and defer this requirement to the parties that require it (i.e: NodeLogger and Leaderboard backend) |
54caa2e
to
e09e482
Compare
b63167d
to
afef228
Compare
7dbdf89
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits regarding type conversion but other than that lgtm
Overview
This PR introduces node uptime metrics + das total sampled headers metrics to support calculating the uptime index proposed by mustafa on the monitoring side.
This PR introduces a new module named
Telemetry
to support node related telemetry. This module can also host all general telemetry and observability that does not interest specific modules.Changes
nodebuilder/node/uptime.go
Checklist
Blocked By
PR: #1537