-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump(metrics): upgrade otel to the latest version #1537
Conversation
fe45d14
to
ff92415
Compare
ff92415
to
a0c8ebc
Compare
a0c8ebc
to
cb9d544
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in branch https://github.com/derrandz/celestia-node/tree/derrandz/test-optl-version-bump which has #1638 against celestiaorg/test-infra#89 and everything is working great 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in branch https://github.com/derrandz/celestia-node/tree/bump_otel_v_x_blackbox_metrics which has #1376 against celestiaorg/test-infra#89 and it seems that there is an issue with Histograms in particular.
Not sure if the API has to change as well, can you look into this @vgonkivs pls?
c46b130
to
166aa45
Compare
Codecov Report
@@ Coverage Diff @@
## main #1537 +/- ##
==========================================
+ Coverage 55.09% 55.14% +0.05%
==========================================
Files 230 230
Lines 14999 14989 -10
==========================================
+ Hits 8263 8266 +3
+ Misses 5853 5841 -12
+ Partials 883 882 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Tested in branch https://github.com/derrandz/celestia-node/tree/derrandz/test-optl-version-bump-x-bbm which has #1376 against celestiaorg/test-infra#89 and everything is working superb. Here's a screenshot of the metrics collected (including uptime metrics). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💸 🚢 🧑💻
Co-authored-by: derrandz <ouaghad.hamza@gmail.com> Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
…totalSampled das metrics + totalSynced sync metrics (#1638) ## Overview This PR introduces node uptime metrics + das total sampled headers metrics to support calculating the uptime index proposed by mustafa on the monitoring side. This PR introduces a new module named `Telemetry` to support node related telemetry. This module can also host all general telemetry and observability that does not interest specific modules. ## Changes - [x] Introduced uptime metrics for node under `nodebuilder/node/uptime.go` - [x] Introduced persistent uptime metrics using datastore to persist node start time - [x] Testing for uptime metrics persistence using the store - [x] Unit testing for uptime metrics - [x] Integration testing for uptime metrics - [ ] e2e testing for uptime metrics ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords ## Blocked By PR: #1537 --------- Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Overview
Updating otel collector to the latest version
Checklist