Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Use proxy/middleware pattern to enable/disable metrics for packages #1705

Closed
derrandz opened this issue Feb 7, 2023 · 0 comments
Labels
area:metrics Related to measuring/collecting node metrics enhancement New feature or request kind:discussion

Comments

@derrandz
Copy link
Contributor

derrandz commented Feb 7, 2023

Implementation ideas

Context

Following a conversation (#1638 (comment)) with @renaynay about the existing pattern (#1638 (comment)) used for metrics in DASer, we would like to implement the instrumentation middleware or proxy pattern to allow easier enabling and disabling of metrics, instead of having to check for nil references when metrics are disabled.

An example of this pattern is available in #1376

@derrandz derrandz added the enhancement New feature or request label Feb 7, 2023
@renaynay renaynay added the area:metrics Related to measuring/collecting node metrics label Feb 8, 2023
@celestiaorg celestiaorg locked and limited conversation to collaborators Dec 20, 2023
@ramin ramin converted this issue into discussion #3036 Dec 20, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
area:metrics Related to measuring/collecting node metrics enhancement New feature or request kind:discussion
Projects
None yet
Development

No branches or pull requests

3 participants