feat(Tearsheet): Move Tearsheet into @carbon/ibm-products-web-components #6204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…eb-components-tearsheet
…github.com/sangeethababu9223/ibm-products into feat/ibm-products-web-components-tearsheet
…eb-components-tearsheet
…github.com/sangeethababu9223/ibm-products into feat/ibm-products-web-components-tearsheet
48aea91 to
070d90e
Compare
…eb-components-tearsheet
…github.com/sangeethababu9223/ibm-products into feat/ibm-products-web-components-tearsheet
…eb-components-tearsheet
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6204 +/- ##
==========================================
- Coverage 78.71% 78.69% -0.02%
==========================================
Files 395 395
Lines 12849 12849
Branches 4248 4248
==========================================
- Hits 10114 10112 -2
- Misses 2735 2737 +2
|
…github.com/sangeethababu9223/ibm-products into feat/ibm-products-web-components-tearsheet
…nto pr/sangeethababu9223/6204
…om:sangeethababu9223/ibm-products into pr/sangeethababu9223/6204
bf5a6a5 to
2cf848d
Compare
davidmenendez
approved these changes
Oct 25, 2024
Closed
elycheea
reviewed
Oct 25, 2024
There was a problem hiding this comment.
Thanks @kennylam @davidmenendez @matthewgallo @sangeethababu9223 for all jumping in to get this set up properly.
One comment, but I’m only posting it so we can open a follow up issue. :)
| # Tearsheet | ||
|
|
||
| > 💡 Check our | ||
| > [Stackblitz](https://stackblitz.com/github/carbon-design-system/carbon/tree/main/packages/web-components/examples/components/tearsheet) |
There was a problem hiding this comment.
We can open a followup issue since our Overview/Docs tabs aren’t appearing right now anyway, but our example links will probably both need some updates.
Merged
via the queue into
carbon-design-system:main
with commit Oct 25, 2024
c21d102
27 checks passed
This was referenced Oct 25, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6183
Move Tearsheet from
@carbon/web-componentsto@carbon/ibm-products-web-componentsWhat did you change?
Tearsheetfolder from core carbon toibm-products-web-components.How did you test and verify your work?
Storybook