Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: netlify check #6294

Closed

Conversation

davidmenendez
Copy link
Contributor

No description provided.

@davidmenendez davidmenendez requested a review from a team as a code owner October 24, 2024 19:18
@davidmenendez davidmenendez requested review from elycheea and AlexanderMelox and removed request for a team October 24, 2024 19:18
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 7ba6c2f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/671be34bd8d2970008b74084
😎 Deploy Preview https://deploy-preview-6294--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 7ba6c2f
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/671be34bcad9970008eaab89
😎 Deploy Preview https://deploy-preview-6294--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (f7c9dd3) to head (7ba6c2f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6294      +/-   ##
==========================================
- Coverage   78.71%   78.69%   -0.02%     
==========================================
  Files         395      395              
  Lines       12849    12849              
  Branches     4248     4248              
==========================================
- Hits        10114    10112       -2     
- Misses       2735     2737       +2     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@davidmenendez
Copy link
Contributor Author

issue was identified- the netlify.toml in the web-components package was causing the issue and simply needed to be removed. should be resolved in this PR #6204

closing this out.

@davidmenendez davidmenendez deleted the wc-netlify-fix branch October 25, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant