-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ibm products web component): theme integration issue #6275
Closed
sangeethababu9223
wants to merge
31
commits into
carbon-design-system:main
from
sangeethababu9223:fix/ibm-proucts-web-components-theme-integration-fix
Closed
fix(ibm products web component): theme integration issue #6275
sangeethababu9223
wants to merge
31
commits into
carbon-design-system:main
from
sangeethababu9223:fix/ibm-proucts-web-components-theme-integration-fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eb-components-tearsheet
…github.com/sangeethababu9223/ibm-products into feat/ibm-products-web-components-tearsheet
…eb-components-tearsheet
…github.com/sangeethababu9223/ibm-products into feat/ibm-products-web-components-tearsheet
…eb-components-tearsheet
…github.com/sangeethababu9223/ibm-products into feat/ibm-products-web-components-tearsheet
…eb-components-tearsheet
…eb-components-tearsheet
…github.com/sangeethababu9223/ibm-products into feat/ibm-products-web-components-tearsheet
…eb-components-tearsheet
❌ Deploy Preview for ibm-products-web-components failed. Why did it fail? →
|
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sangeethababu9223
changed the title
Fix/ibm proucts web components theme integration issue
fix(ibm products web components theme) integration issue
Oct 23, 2024
sangeethababu9223
changed the title
fix(ibm products web components theme) integration issue
fix(ibm products web components theme): integration issue
Oct 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6275 +/- ##
==========================================
- Coverage 78.71% 78.65% -0.07%
==========================================
Files 395 395
Lines 12849 12849
Branches 4248 4248
==========================================
- Hits 10114 10106 -8
- Misses 2735 2743 +8
|
sangeethababu9223
changed the title
fix(ibm products web components theme): integration issue
fix(ibm products web component): theme integration issue
Oct 23, 2024
@sangeethababu9223 I think these were also addressed in #6204 but feel free to reopen if there’s anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR to check theme integration issue in Web components package