Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ibm products web component): theme integration issue #6275

Conversation

sangeethababu9223
Copy link
Member

Test PR to check theme integration issue in Web components package

sangeethababu9223 and others added 25 commits October 11, 2024 14:04
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for ibm-products-web-components failed. Why did it fail? →

Name Link
🔨 Latest commit 86061e7
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/671b68539ecef70008aef42d

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 86061e7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/671b6853c03620000830d230
😎 Deploy Preview https://deploy-preview-6275--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sangeethababu9223 sangeethababu9223 changed the title Fix/ibm proucts web components theme integration issue fix(ibm products web components theme) integration issue Oct 23, 2024
@sangeethababu9223 sangeethababu9223 changed the title fix(ibm products web components theme) integration issue fix(ibm products web components theme): integration issue Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.65%. Comparing base (f7c9dd3) to head (86061e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6275      +/-   ##
==========================================
- Coverage   78.71%   78.65%   -0.07%     
==========================================
  Files         395      395              
  Lines       12849    12849              
  Branches     4248     4248              
==========================================
- Hits        10114    10106       -8     
- Misses       2735     2743       +8     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@sangeethababu9223 sangeethababu9223 changed the title fix(ibm products web components theme): integration issue fix(ibm products web component): theme integration issue Oct 23, 2024
@elycheea
Copy link
Contributor

@sangeethababu9223 I think these were also addressed in #6204 but feel free to reopen if there’s anything else.

@elycheea elycheea closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants