feat(MultiSelect): new option to display title of the selected items #5886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit da33199 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit da33199 https://deploy-preview-5886--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 2429b05 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 2429b05 https://deploy-preview-5886--carbon-components-react.netlify.app |
|
I really liked it! It would be a great addition to components |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new option that allows the title of the selected items to be displayed and not just the counter as it is currently.
It was also added the option to display the counter together with the titles because when many items are selected, it may not be possible for all of them to be displayed, in which case scrolling is possible.
This proposed change was made thinking about the usability of the user who will see which items were selected even after closing the selection list, and also allows any of the items to be deselected.
Any suggestions will be highly appreciated.