Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tags] Tag input, tags group #2422

Closed
Pablodotnet opened this issue May 8, 2019 · 12 comments
Closed

[Tags] Tag input, tags group #2422

Pablodotnet opened this issue May 8, 2019 · 12 comments

Comments

@Pablodotnet
Copy link

Summary

Development of an input where you will write a word or phrase, press enter and it will add a tag, it could be used with autocomplete or without it. I will share the design with autocomplete.

Justification

Some of the most popular ui frameworks have it and now we are needing it in an actual project but carbon does not have it implemented.

Desired UX and success metrics

It's basically a text input in which we are going to type a word or phrase, press enter and a tag will be displayed inside that input, it could be on the same row of the input or display above it BUT it should be looking like it's inside the input, this input can being used with autocomplete or without it, you'll watch it in the design.

"Must have" functionality

Basic input and with Autocomplete option

Specific timeline issues / requests

We need it for a very important project but we will try to make a basic solution meanwhile this component is officially developed to carbon.

Available extra resources

The design of the input, I think this designs follows correctly the guidelines so I think is the perfect design to be used for it.
Screen Shot 2019-05-08 at 2 27 47 PM

@dakahn
Copy link
Contributor

dakahn commented May 8, 2019

Hello! 👋

Looks to me like our filterable Tags component is what you're looking for here, friend.
https://www.carbondesignsystem.com/components/tag/code
2019-05-08 16_03_03-Carbon Design System

@Pablodotnet
Copy link
Author

Hello! 👋

Looks to me like our filterable Tags component is what you're looking for here, friend.
https://www.carbondesignsystem.com/components/tag/code
2019-05-08 16_03_03-Carbon Design System

No, I don't mean the single tag element, I'm talking about a complete input field where you write the tag name, press enter and tag will be added, not a tag with an input inside, watch this example:

https://material.angular.io/components/chips/overview

Screen Shot 2019-05-08 at 4 10 58 PM

@Pablodotnet
Copy link
Author

Pablodotnet commented May 8, 2019

Here's another example:
Demo: https://angular-mfppay.stackblitz.io/
Repository: https://github.com/Gbuomprisco/ngx-chips

@asudoh
Copy link
Contributor

asudoh commented May 9, 2019

@Pablodotnet Does either of what @emyarod brought up sound close to what you need? If so let us know and we can merge the issue. Thanks!

@Pablodotnet
Copy link
Author

Yeah it's something like that, you can use this design and use the functionality they recommend too on those issues, we personally need it for angular

@asudoh
Copy link
Contributor

asudoh commented May 9, 2019

OK @Pablodotnet make sure you add thumb-up to the issue description to the closer one - We can use that info to determine the priority. Contributions will be nice as always. Thanks!

@shixiedesign shixiedesign changed the title Feature: Tag Input / Chip Input / Pill Input [Tags] Tag input, tags group May 13, 2019
@Pablodotnet
Copy link
Author

I would like to contribute with this feature for angular components...

@asudoh
Copy link
Contributor

asudoh commented May 14, 2019

OK definitely open a ticket at https://github.com/IBM/carbon-components-angular for discussion!

@Pablodotnet
Copy link
Author

@asudoh I have talked with angular components devs and they say I have to make the component here first, so I would like to contribute with it here.

@asudoh
Copy link
Contributor

asudoh commented May 17, 2019

I see - Closing this for now given you told us that this is close to #2640 or #2571. Let us know which one it is so we can track the progress - Thanks!

@asudoh asudoh closed this as completed May 17, 2019
@chrisconnors-ibm
Copy link
Contributor

@Pablodotnet that's awesome! thanks for pitching in. remember there are 5 things required for submissions to make it to our main branch:

  1. A Design for the enhancement or component
  2. a specification for development
  3. a coded component
  4. a symbol to add to the sketch library
  5. documentation (in gh and the carbon website)

I think 1 and 2 exist, you're pitching in on 3, but make sure we have someone in mind for 4 and 5, since we can't put the code in production as part of our master GA branch without them (this is true for all of our components too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants