Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Component]: Tag List #2640

Closed
5 tasks
bellsworth13 opened this issue May 7, 2018 · 9 comments
Closed
5 tasks

[New Component]: Tag List #2640

bellsworth13 opened this issue May 7, 2018 · 9 comments

Comments

@bellsworth13
Copy link
Contributor

[New Component]: TagList

Detailed description

We want to create a component which will manage a list of tags.

Is this a feature request (new component, new icon), a bug, or a general issue?

This is a feature request for a new component.

  • It should have the following properties:
  • items (tags)
  • limit/overflow (a number of tags that should show before showing overflow)
  • condense (when the list should be shown as just a number - might not have to be separate form overflow)
  • sort (function will decide how to order the tags)
  • isEditable (will contain icon button)

Additional information

image

image

@joshblack
Copy link
Contributor

cc @carbon-design-system/design just so you all are aware about this pattern. Feel free to comment if you feel like this is better served in an add-on or if it's valid to be brought into core 👍

For right now, I believe the work is going into adding it into core, right @bellsworth13? But we can always easily transition over into an add-on if the work is more appropriate there 🙂

@bellsworth13
Copy link
Contributor Author

@joshblack Yes, right now I am working on adding it into core!

@aagonzales
Copy link
Member

If we're adding it to the core, we should probably do a design review to make sure its not breaking any rules. Is this the work Virginia has been working on? Because I think @tay-aitken has been involved in that work.

We'll need to get the native design assets so we can our Carbon resources.

@bellsworth13
Copy link
Contributor Author

Yes, this is related to the work Virginia has been working on. Would you want to do the design review before or after I make a PR?

@aagonzales
Copy link
Member

Ideally, it would be done before you started coding it but we can review it in the PR if you already have it. We just need to make sure it fits a common usecase and follow are styles and patterns.

@stale
Copy link

stale bot commented May 2, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@carbon-bot carbon-bot transferred this issue from carbon-design-system/carbon-components-react May 9, 2019
@carbon-bot
Copy link
Contributor

Hi there! 👋 If you're wondering why this issue was moved, we're currently updating our repo structure so that every package is found in the same project.

This should not have any impact for you, but we wanted to give you a heads up in case you were wondering what is going on. If you have any questions, feel free to reach out to us on Slack or contact us at: carbon@us.ibm.com. Thanks!

@akulo
Copy link

akulo commented May 22, 2019

Hi there. Is there any established design to render multi-select component like this
image

@ulvidamirli
Copy link

@akulo Did you find a solution for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants