Read only form controls

[shixiedesign]

A read only variant of Text input is suggested here: carbon-design-system/carbon-contribution#13 (comment)

The “Disabled” option is not viable, as the label and entered data is not accessible. Proposal is to simply remove the line at the base of the "Filled" version of the component, so that it closely matches with the Disabled component, but passes accessibility.

Overview of component (updated May 13)

• Read-only variant will be keeping underline and dropping the background of the field. We need the underline for low-vision users to recognize this as a text field. Also loosing the underline makes the element a button-style, which would be confusing.
• Not moving the text position after all. Keeping text 16px away from left of border helps with preserving the form structure.
• Regular text cursor and allows text selecting
• Add not-editable icon, icon in PR Add edit--off icon svg & update metadata.yml #2710
• Optional tooltip when hovering not-editable icon, to provide reason for the field being read-only
• Overflow text in the field will show in tooltip on hover
• Should be considered a state, possible readonly attribute
• Follow the standard readonly attribute: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-readonly

Design spec (updated May 13)

In context explorations:

[chrisconnors-ibm]

awaiting specification.

[lovemecomputer]

i have a couple of questions for implementation:

• semantic: if this is a unique state, should we think of it as being labelled read-only/readOnly?
• design: have we decided on design spec for this?

[elizabethsjudd]

From my understanding the implementations should follow the standard readonly attribute: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-readonly

[shixiedesign]

Thanks everyone for the thoughts and discussion. I've updated the original issue description with spec, and summarized all the comments here. This issue is now ready for development!

[shixiedesign]

Note

Moving issue back to visual design stage to figure out the following potential changes:

• Potentially removing not-allowed cursor. Waiting on feedback.
• Lock icon with tooltip containing reason why field is read-only

[lovemecomputer]

should we afford for any kind of status messages/icon/tooltip/etc as part of the pattern for readonly input fields? (typically on forms, if i can't edit something, i want to know why and where i need to go to be able to do so).

i can see the case for product teams being responsible for this, but if we have a particular suggested pattern for how to handle that hinting, we could build it in. (e.g. a lock icon in in the field that can launch a tooltip)

[shixiedesign]

Lock icon is a good idea @lovemecomputer ! Lemme try it out...

[quarryboy]

@lee-chase ah i see where the confusion is. this is a practical UX problem. the "light" background is not intended to match the default background. the intended use of the "light" setting is an alternate setting for when the form item is on a background that is not the default.

meaning: if the white theme is used, then a gray10 background will be applied to the component by default. however, there are times where the component is placed on a gray10 background (rather than white) and contrast is still required to differentiate the background color of the component from its surroundings. the alternate "light" version will instead have a white background to create the appropriate contrast.

does that make sense?

[lee-chase]

Makes sense @quarryboy, although I suspect as a result that 'light' will have been misused in places.

[quarryboy]

@lee-chase i feel like we could’ve put money on the line. 😉 It’s almost a guarantee that bit has been misused!

[lee-chase]

@quarryboy @sstrubberg

NOTE:

• Carbon form component example http://localhost:3000/?path=/story/components-form--default
• Date picker, while not a single form component, is built using text boxes and hence could be used on a form. (has no example on form storybook)
• Dropdown is not a form component and will not be submitted with a form. Unlike a select has an aria role applied to its popup list.
• Combobox is a form input element with aria-role set as per a default input with list attribute. (has no example on form storybook)
• Multiselect is not a form component and will not be submitted with a form. Unlike select has an aria role applied to its popup list.
• Select is a form component that can have a role of ether
  • https://www.w3.org/TR/html-aria/#docconformance
  • combobox with no multiple attribute and no size attribute > 1
  • listbox otherwise
• Slider has an input of type number (should this be a range?) which would get submitted with a form, but has the wrong constructed ID which will confuse. (has no example on form storybook)
• Time picker, while not a single form component, comprises a text box and two selects and hence could be used on a form. (has no example on form storybook)
• Toggle is not a form component and will not be submitted with a form.

[lee-chase]

@quarryboy The toggle button is offset by 1px towards the center in read only (off and on) size 'md'. Is that an accident?

Also you lose the check mark on the 'sm' size, can you confirm this is deliberate?

[chrisconnors-ibm]

tbh I like it, but if it is intentional I think I'd expect the light source to remain consistent between the two states. :)

[quarryboy]

@lee-chase i think a call between Mike Eacker and i would solve quite a bit rather than discussing so many threads in here.

regarding the toggle button: this may also be better for an in-person call. are you asking about redesigning the toggles for the enabled state as well as what i'm seeing in the image above is not the read-only design.

[JordanWSmith15]

@shixiedesign @tay1orjones I see that this is being resolved in the code, but I do not see any guidance on the design site. Can someone point me to the final design guidance for read-only inputs?

[sstrubberg]

Here is the epic tracking the work @JordanWSmith15. You can also find the pattern work here as a PR, waiting to be approved and merged.

[sstrubberg]

Closing this issue in favor of the epic I mentioned above.