-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Text input] Dynamic list #2679
Comments
One UX question @shixiedesign - The CodeSandbox demo keeps the entered text after addition. Should we do the same or should we clear the text box after addition? Thanks! |
Good catch! Yes I believe that's a bug. Text field should be cleared in anticipation of different content to be entered. |
Yep, I just quickly made that codesandbox.io demo code. The input should clear.
|
For the entered items, would it make sense to use the readonly variant from #2177? |
@werdnanoslen I had the same thought, though Read-only variant gets the |
Yeah, definitely don't think that cursor should be used here. We're also not using the |
We needed the underline to show that it's still a |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
not stale |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
not stale |
Still keeping an eye on this. Component enhancements are not high on the prioritization list recently. @werdnanoslen Could you provide a few full page screenshots of this component in context? |
@shixiedesign They only exist in Sketch/Invision right now, but it will go into development soon. It's also for an unreleased product, so I'll share on internal channels... |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
not stale |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
@shixiedesign we have a locally deployable version that I'll DM you |
@shixiedesign @werdnanoslen where do we stand with this issue? What are the next steps? What else is needed (doing some planning so what if anything does Carbon need to do for this)? |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
@aagonzales I'm not sure what next steps are, but just keeping this issue open until we figure it out... |
Thanks for the proposal! It looks like we've had some good conversations around this request. We thank this is more suitable in a PAL or sub-system library. We'll close this issue for its addition to the core Carbon library. Please reopen is you think this is something that needs to be reconsidered. |
Feature description
Design & feature contribution from Andrew Nelson: carbon-design-system/carbon-contribution#10
Demo: https://codesandbox.io/s/523355y4l
Design spec
After conversation in contribution issue, we arrived at the following design for this item:
The text was updated successfully, but these errors were encountered: