Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text input] Dynamic list #2679

Closed
shixiedesign opened this issue May 10, 2019 · 21 comments
Closed

[Text input] Dynamic list #2679

shixiedesign opened this issue May 10, 2019 · 21 comments
Assignees
Labels
proposal: open This request has gone through triaging. We're determining whether we take this on or not.

Comments

@shixiedesign
Copy link
Contributor

Feature description

Design & feature contribution from Andrew Nelson: carbon-design-system/carbon-contribution#10

The goal was to allow a user to quickly build a list of items. I'm personally using this pattern in a couple of places to allow a user to type a list of emails and make a binary admin/not-admin selection for each one. This would not have been possible as a csv list in a text area, and the table component is far too heavy visually for such a simple list.

Cyrus Furtado (@cfurtado on Slack & IBM Github) on my team built it, and I designed it.

Demo: https://codesandbox.io/s/523355y4l

Design spec

After conversation in contribution issue, we arrived at the following design for this item:

image

@asudoh
Copy link
Contributor

asudoh commented May 10, 2019

One UX question @shixiedesign - The CodeSandbox demo keeps the entered text after addition. Should we do the same or should we clear the text box after addition? Thanks!

@shixiedesign
Copy link
Contributor Author

Good catch! Yes I believe that's a bug. Text field should be cleared in anticipation of different content to be entered.

@werdnanoslen
Copy link
Contributor

werdnanoslen commented May 11, 2019 via email

@werdnanoslen
Copy link
Contributor

For the entered items, would it make sense to use the readonly variant from #2177?

@shixiedesign
Copy link
Contributor Author

@werdnanoslen I had the same thought, though Read-only variant gets the not-allowed cursor, which would be confusing and user could miss the fact that the button is still clickable. We might remove the not-allowed cursor in our specification. It might be an overkill to demonstrate the field is not editable. Thoughts?

@werdnanoslen
Copy link
Contributor

Yeah, definitely don't think that cursor should be used here. We're also not using the border-bottom on the entered items, so it's more like a tile component than an input component, right?

@shixiedesign
Copy link
Contributor Author

We needed the underline to show that it's still a text-input and not a button, even though read-only.
Agreed, might make more sense as a tile varian.

@stale
Copy link

stale bot commented Jun 12, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jun 12, 2019
@werdnanoslen
Copy link
Contributor

not stale

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Jun 12, 2019
@stale
Copy link

stale bot commented Jul 12, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jul 12, 2019
@werdnanoslen
Copy link
Contributor

not stale

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Jul 12, 2019
@shixiedesign
Copy link
Contributor Author

Still keeping an eye on this. Component enhancements are not high on the prioritization list recently. @werdnanoslen Could you provide a few full page screenshots of this component in context?

@werdnanoslen
Copy link
Contributor

@shixiedesign They only exist in Sketch/Invision right now, but it will go into development soon. It's also for an unreleased product, so I'll share on internal channels...

@stale
Copy link

stale bot commented Aug 30, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Aug 30, 2019
@werdnanoslen
Copy link
Contributor

not stale

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Aug 30, 2019
@stale
Copy link

stale bot commented Sep 29, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Sep 29, 2019
@werdnanoslen
Copy link
Contributor

@shixiedesign we have a locally deployable version that I'll DM you

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Sep 30, 2019
@aagonzales
Copy link
Member

aagonzales commented Oct 4, 2019

@shixiedesign @werdnanoslen where do we stand with this issue? What are the next steps? What else is needed (doing some planning so what if anything does Carbon need to do for this)?

@stale
Copy link

stale bot commented Nov 3, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Nov 3, 2019
@werdnanoslen
Copy link
Contributor

@aagonzales I'm not sure what next steps are, but just keeping this issue open until we figure it out...

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Nov 4, 2019
@joshblack joshblack added proposal: open This request has gone through triaging. We're determining whether we take this on or not. and removed type: enhancement 💡 impact: low labels Jan 13, 2020
@designertyler
Copy link
Contributor

Thanks for the proposal! It looks like we've had some good conversations around this request.

We thank this is more suitable in a PAL or sub-system library. We'll close this issue for its addition to the core Carbon library. Please reopen is you think this is something that needs to be reconsidered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal: open This request has gone through triaging. We're determining whether we take this on or not.
Projects
None yet
Development

No branches or pull requests

7 participants