Read only number input #12384
Merged
Read only number input #12384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tay1orjones
approved these changes
Oct 25, 2022
packages/styles/scss/components/number-input/_number-input.scss
Outdated
Show resolved
Hide resolved
74294d2 to
382d219
Compare
laurenmrice
requested changes
Nov 7, 2022
There was a problem hiding this comment.
Looking good! Just a couple comments:
-/+ controls
On hover:
- The cursor should be the Arrow icon, not the pointer icon.
- The browser-based tooltips for decrement/increment should not appear.
- When hovering over the controls area there is a bug with a slight change in color that appears on the divider rule.
@laurenmrice the cursor is arrow on button hover, the tooltip (Chrome 107, Safari 16, Firefox 106) does not display. Perhaps the build was out of date. Fixed the divider color.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2177
Adjusts the readOnly NumberInput based on #2177.
Closes #12613
Changelog
Changed
Testing / Reviewing
Reviewed the result in Storybook, there is no readOnly test for text input.