Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: readonly text area #12388

Merged
merged 8 commits into from
Dec 2, 2022
Merged

feat: readonly text area #12388

merged 8 commits into from
Dec 2, 2022

Conversation

lee-chase
Copy link
Member

Contributes to #2177

Adds the readonly feature to the TextArea component

Changelog

Changed

  • adds test-are__wrapper--readonly class
  • adds readonly attribute to input
  • adds readonly property to proptypes
  • adds a readonly test for immutibility
  • makes the background transparent

Testing / Reviewing

Reviewed the result in Storybook added readonly test.

@lee-chase lee-chase requested a review from a team as a code owner October 25, 2022 14:32
@lee-chase lee-chase changed the title feat: readonly text input feat: readonly text area Oct 25, 2022
@netlify
Copy link

netlify bot commented Oct 25, 2022 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 54fd1ac
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/638a4411b2fa430008b5fc61
😎 Deploy Preview https://deploy-preview-12388--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 25, 2022 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 54fd1ac
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/638a44105f54fd00086c2a4b
😎 Deploy Preview https://deploy-preview-12388--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lee-chase lee-chase requested a review from a team as a code owner October 25, 2022 16:01
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Nov 14, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the status: ready to merge 🎉 label.

@alisonjoseph alisonjoseph requested review from a team and aagonzales and removed request for a team November 15, 2022 13:39
@tay1orjones tay1orjones mentioned this pull request Nov 15, 2022
Closed
2 tasks
@sstrubberg sstrubberg mentioned this pull request Nov 17, 2022
Closed
aagonzales
aagonzales approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kodiakhq kodiakhq bot merged commit 70e2231 into carbon-design-system:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagonzales aagonzales aagonzales approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@aledavila aledavila Awaiting requested review from aledavila aledavila was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lee-chase @alisonjoseph @tay1orjones @aagonzales @aledavila @sstrubberg