Update to Genomicsdb 1.1.2.2 with Linux and MacOS shared libraries packaged #6206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ac OSX shared libraries are included in genomicsdb.jar
* Move vid combine protobuf mapping overrides from GenomicsDB ExportConfiguration to Import * Comment out MOVE_TO_FORMAT as it is not used as yet * Change AS_QUALapprox combine operation to element wise int sum
nalinigans
commented
Oct 9, 2019
| @@ -33,6 +33,15 @@ public void testGenomicsDBInClassPath(){ | |||
| Assert.assertNotNull(GenomicsDBLibLoader.class.getResource(path), "Could not find the genomicsdb binary at " + path); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testGenomicsDBJarForNativeLibraries() { | |||
There was a problem hiding this comment.
Test for Linux and MacOS shared native libraries in genomicsdb jar.
droazen
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to 1.1.2.2 with Linux and MacOS shared libraries packaged and added junit to check if they are in the genomicsdb-.jar.
Also brought back #6188 and #6190 into this branch which had to be reverted before - see #6204.