Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert upgrade to GenomicsDB 1.1.2 to fix a regression #6204

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

droazen
Copy link
Contributor

@droazen droazen commented Oct 8, 2019

GenomicsDB 1.1.2 is missing the Mac version of the GDB native library (libtiledbgenomicsdb.dylib). This PR reverts the two recent GDB PRs (#6190 and #6188), and takes us back to the previous release of GenomicsDB, which didn't have this problem.

I've asked @nalinigans to submit a fresh PR once there's a GenomicsDB release that fixes this issue, and also to add a GATK test that asserts the .dylib is present on the classpath.

@droazen droazen requested a review from jamesemery October 8, 2019 14:40
Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection to these changes, especially since this is just bringing us back to where we were in genomicsDB in the last release. We should spawn a ticket to track reintroducing these improvements and perhaps we should also add a macos test to our travis array so we can catch this kind of issue in the future? I think there is a macOS VM availible on travis that we could rerun some of the integration tests on.

@nalinigans
Copy link
Collaborator

nalinigans commented Oct 8, 2019

I have no objection to these changes, especially since this is just bringing us back to where we were in genomicsDB in the last release. We should spawn a ticket to track reintroducing these improvements and perhaps we should also add a macos test to our travis array so we can catch this kind of issue in the future? I think there is a macOS VM availible on travis that we could rerun some of the integration tests on.

Yes, travis has macOS VM. It is very slow, so would recommend only sanity checks on it.

@nalinigans nalinigans closed this Oct 8, 2019
@droazen droazen reopened this Oct 8, 2019
@nalinigans
Copy link
Collaborator

@droazen, working on a release right now. Thanks.

@droazen droazen merged commit af1bc4f into master Oct 8, 2019
@droazen droazen deleted the dr_revert_genomicsdb_regression branch October 8, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants