Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GenomicsDB 1.1.2 #6188

Merged
merged 2 commits into from
Sep 27, 2019
Merged

Move to GenomicsDB 1.1.2 #6188

merged 2 commits into from
Sep 27, 2019

Conversation

nalinigans
Copy link
Collaborator

@nalinigans nalinigans commented Sep 26, 2019

These are the changes relevant to gatk -

  • Allow changes for allele specific and other annotations to vid file via GenomicsDBImporter without hardcoding them in genomicsdb. See GenomicsDB Fix 39. Thanks @mlathara.
  • Fix for
    BUGreportGATK-07-19-19 reported by @bshifaw where a large ploidy + number of genotypes was leading to math overflow. The overflow is now caught and GenomicsDB stops enumerating genotypes for this case. Thanks @kgururaj.
  • Fix for missing libcurl in the native GenomicsDB library - Issue GenomicsDBImport java.lang.ExceptionInInitializerError #6122
  • Fix to avoid crashing when vcfbufferstream from htslib happens to be invalid. This check was put in response to the Forum Issue 59667. Note that the test vcfs sample2, sample3 and sample4 had to be changed to be htslib compliant for importing and to run org.broadinstitute.hellbender.tools.walkers.mutect.CreateSomaticPanelOfNormalsIntegrationTest successfully.
  • Allow for native GenomicsDBExceptions to be propagated as java IOExceptions to allow gatk to gracefully handle the exception by printing out relevant information. See GenomicsDB Fix 68.
  • Fix for issues using vid protobuf interface to pass vid information and there is more than one config. Thanks @mlathara.

@nalinigans nalinigans requested a review from droazen September 26, 2019 21:46
Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@droazen droazen merged commit 712bfc4 into master Sep 27, 2019
@droazen droazen deleted the nalini_1.1.2 branch September 27, 2019 14:47
droazen added a commit that referenced this pull request Oct 8, 2019
droazen added a commit that referenced this pull request Oct 8, 2019
* Revert "Cleanup GenomicsDB vid combine protobuf mapping overrides (#6190)"

This reverts commit 609dafe.

* Revert "Move to GenomicsDB 1.1.2 (#6188)"

This reverts commit 712bfc4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants