This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Remove destroy from popup menus #9128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Muon with brave/muon#161 Auditors: @bridiver, @bbondy
darkdh
added a commit
to brave/muon
that referenced
this pull request
Jun 6, 2017
``` All menus on aura platforms no longer use the nested message loop code path of MenuController. On Mac non-native menus also no longer use the nested message loop. While native menus are handled vis menu_runner_impl_cocoa, which does block. This change removes the Nested Message Loop code paths from MenuController. Additionally some tests which specifically were for nested message loops below asynchronous menus, have been either transitioned, or removed if redundant. ``` https://chromium.googlesource.com/chromium/src.git/+/b31c887a2d14761b078f329629f1d3469106b891%5E%21/ It also forced menu to be async so we must make sure menu runner is alive until menu closed. requires brave/browser-laptop#9128 fix brave/browser-laptop#9100 Auditors: @bsclifton, @bridiver, @bbondy
|
moved to 0.16.x due to required by CR59 context menu regression |
darkdh
added a commit
to brave/muon
that referenced
this pull request
Jun 6, 2017
``` All menus on aura platforms no longer use the nested message loop code path of MenuController. On Mac non-native menus also no longer use the nested message loop. While native menus are handled vis menu_runner_impl_cocoa, which does block. This change removes the Nested Message Loop code paths from MenuController. Additionally some tests which specifically were for nested message loops below asynchronous menus, have been either transitioned, or removed if redundant. ``` https://chromium.googlesource.com/chromium/src.git/+/b31c887a2d14761b078f329629f1d3469106b891%5E%21/ It also forced menu to be async so we must make sure menu runner is alive until menu closed. requires brave/browser-laptop#9128 fix brave/browser-laptop#9100 Auditors: @bsclifton, @bridiver, @bbondy
|
fix #9100 |
|
Removed the milestone as this PR was reverted. Let's add that for another PR which will be opened later. |
|
Also don't we need an issue to track? |
|
it was only reverted because I accidentally merged too soon |
|
it is merged here 7eb2f28 |
|
Manually re-added with db2027a; I updated milestone appropriately (since it was deployed with 0.16.13) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove destroy from popup menus; it now happens when menu is hidden in Muon with brave/muon#161
Auditors: @bridiver, @bbondy
DON'T MERGE UNTIL brave/muon#161 IS MERGED
Submitter Checklist:
git rebase -ito squash commits (if needed).Reviewer Checklist:
Tests
#5470