Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

adding release notes for 0.18.14 #10174

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Conversation

alexwykoff
Copy link
Contributor

Audtiors : @bbondy @bsclifton

@alexwykoff alexwykoff requested review from bbondy and bsclifton July 27, 2017 15:20
CHANGELOG.md Outdated
- Fixed adding a bookmarks folder makes the browser unresponsive in Sync. ([#9745](https://github.com/brave/browser-laptop/issues/9745))
- Fixed bookmark deletion may lead to duplicated bookmarks in Sync. ([#9724](https://github.com/brave/browser-laptop/issues/9724))
- Fixed blank tabs bar when increasing the number of tabs per tab set. ([#7806](https://github.com/brave/browser-laptop/issues/7806))
- Updated to Chromium 60. ([#9947](https://github.com/brave/browser-laptop/issues/9947))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the full Chromium version here.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see #10029 called out- since this issue caused a lot of grief for LastPass users in 0.17.x (it affects 0.17.17 and newer builds), I think we should move it to the top of the fixed section

CHANGELOG.md Outdated
@@ -1,5 +1,38 @@
# Changelog

## [0.18.13](https://github.com/brave/browser-laptop/releases/tag/v0.18.13dev)
- Added a welcome screen for first time users. ([#9423](https://github.com/brave/browser-laptop/issues/9423))
- Added Chromium spell checker. ([#9880](https://github.com/brave/browser-laptop/issues/9880))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it would be good to call out "(in place of Electron spell checker)"

CHANGELOG.md Outdated
- Added "Hide Lower" button on Brave Payments. ([#9137](https://github.com/brave/browser-laptop/issues/9137))
- Optimized sending messages only to needed windows instead of all windows. ([#9701](https://github.com/brave/browser-laptop/issues/9701))
- Fixed showing the URL in the location bar for invalid URLs (instead of about:error). ([#2025](https://github.com/brave/browser-laptop/issues/2025))
- Fixed opening a context menu freezes video (ex: Youtube). ([#5470](https://github.com/brave/browser-laptop/issues/5470))
Copy link
Contributor

@NejcZdovc NejcZdovc Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsclifton @bbondy in which PR for 0.18 did we fix this. I think that async menu was already implemented in Jun,probably in 0.16.x

Copy link
Member

@bsclifton bsclifton Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @NejcZdovc - this was def 0.16.x 😄

@alexwykoff
Copy link
Contributor Author

updated, left 5470 in there because it was tied to pr #9128

@bsclifton
Copy link
Member

bsclifton commented Jul 27, 2017

@alexwykoff whoops- I think that was a miss on our part. That was released with Chromium 59 actually, which means it was in 0.16.x (click here for the commit log). I'll update the milestone for the issue and the PR to properly be 0.16.x. After removing that, I think we're good for a merge 😄

@bsclifton bsclifton added this to the 0.18.x Release milestone Jul 28, 2017
@bsclifton bsclifton force-pushed the add_0_18_13_release_notes branch from c9838f5 to 4249cfc Compare July 28, 2017 16:13
@bsclifton
Copy link
Member

Removed the async menu option from the releases page and from the notes. Also squashed commits

@alexwykoff in the future, would you PR against master? This way it's similar to other PRs (where you merge then cherry-pick back until the selected milestone)

@bsclifton bsclifton merged commit ae8e703 into 0.18.x Jul 28, 2017
@bsclifton bsclifton deleted the add_0_18_13_release_notes branch July 28, 2017 16:14
@bsclifton bsclifton changed the title adding release notes for 0.18.13 adding release notes for 0.18.14 Jul 28, 2017
bsclifton added a commit that referenced this pull request Jul 28, 2017
bsclifton added a commit that referenced this pull request Jul 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants