This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Context menus not working with C59 #9100
Assignees
Milestone
Comments
darkdh
added a commit
to brave/muon
that referenced
this issue
Jun 6, 2017
``` All menus on aura platforms no longer use the nested message loop code path of MenuController. On Mac non-native menus also no longer use the nested message loop. While native menus are handled vis menu_runner_impl_cocoa, which does block. This change removes the Nested Message Loop code paths from MenuController. Additionally some tests which specifically were for nested message loops below asynchronous menus, have been either transitioned, or removed if redundant. ``` https://chromium.googlesource.com/chromium/src.git/+/b31c887a2d14761b078f329629f1d3469106b891%5E%21/ It also forced menu to be async so we must make sure menu runner is alive until menu closed. requires brave/browser-laptop#9128 fix brave/browser-laptop#9100 Auditors: @bsclifton, @bridiver, @bbondy
darkdh
added a commit
to brave/muon
that referenced
this issue
Jun 6, 2017
``` All menus on aura platforms no longer use the nested message loop code path of MenuController. On Mac non-native menus also no longer use the nested message loop. While native menus are handled vis menu_runner_impl_cocoa, which does block. This change removes the Nested Message Loop code paths from MenuController. Additionally some tests which specifically were for nested message loops below asynchronous menus, have been either transitioned, or removed if redundant. ``` https://chromium.googlesource.com/chromium/src.git/+/b31c887a2d14761b078f329629f1d3469106b891%5E%21/ It also forced menu to be async so we must make sure menu runner is alive until menu closed. requires brave/browser-laptop#9128 fix brave/browser-laptop#9100 Auditors: @bsclifton, @bridiver, @bbondy
|
This should be working now, closing but pls test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Did you search for similar issues before submitting this one?
yes
Describe the issue you encountered:
Right click on content or UI, no context menu
Platform (Win7, 8, 10? macOS? Linux distro?):
Tested on Windows, but probably all.
Brave Version (revision SHA):
be76cd3
Steps to reproduce:
Actual result:
No context menu
Expected result:
Context menu
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
No
Can this issue be consistently reproduced?
Yes
The text was updated successfully, but these errors were encountered: