Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Properly detect active password manager in contentSettings #3540

Merged
merged 1 commit into from
Aug 30, 2016
Merged

Properly detect active password manager in contentSettings #3540

merged 1 commit into from
Aug 30, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.

Previous code would fail for anyone who had a session before PW manager was simplified down to a single choice, because they did not have ACTIVE_PASSWORD_MANAGER set.

Auditors: @dandart

Fixes #3516

… has the logic to default if not set).

Previous code would fail for anyone who had a session before PW manager was simplified down to a single choice, because they did not have ACTIVE_PASSWORD_MANAGER set.

Auditors: @dandart

Fixes #3516
@bbondy
Copy link
Member

bbondy commented Aug 30, 2016

pls write out tests and tag with manual steps specified for the issue. Pls make sure to try the tests :) And also ping Alex explicitly to try the steps. I want to make sure we're putting an end to this thread of bugs.

@bbondy bbondy merged commit fa24f89 into brave:master Aug 30, 2016
@bbondy
Copy link
Member

bbondy commented Aug 30, 2016

++ merged

@bsclifton
Copy link
Member Author

bsclifton commented Aug 30, 2016

Before verifying the fix, please make sure you have an account created here:
https://trac.torproject.org/projects/tor/login

To verify the fix

Case where PW manager was set but wasn't respected after upgrade

  • Ensure all Brave instances are closed
  • Download session-store-1_bsc0.11.1.zip (0.11.1 session; 1Password enabled)
  • Unzip / move this session file to the appropriate location (Mac is ~/Libraries/Application\ Support/brave/), making sure to rename it as session-store-1
  • Install a version of Brave which has the fix
  • Launch Brave and navigate to Preferences > Security
  • Notice that 1Password is selected
  • Navigate to https://trac.torproject.org/projects/tor/login
  • Login using credentials you have
  • You will NOT be prompted to remember this user/pass, as expected (1Password may prompt you).

@bsclifton
Copy link
Member Author

cc: @alexwykoff to try the steps sometime tomorrow

@bsclifton bsclifton deleted the fix-pw-no-prompt branch August 30, 2016 19:52
@luixxiul luixxiul added this to the 0.11.6dev milestone Sep 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants