Passwords are not saved using default settings

[danwdart]

Did you search for similar issues before submitting this one?
yes, but oddly people are suggesting this does work

Describe the issue you encountered:
I expected brave to save the passwords I had entered, but it isn't doing that despite having "Brave built-in" instead of "Do not manage my passwords".

Expected behavior:
For my passwords to be saved

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Ubuntu 16.04
• Brave Version:
  0.11.5 (latest, checked no updates available)
• Steps to reproduce:
  1. go to a site that would require passwords
  2. enter credentials
  3. return later - no passwords saved
• Any related issues:
  Not that I'm aware of.

[bbondy]

/cc @bsclifton @alexwykoff can you repro? If so we should block on this.
Possibly also related to an upgrade session store on an older version before the password manager drop down task, if so we should also block on this.

[bsclifton]

Checking this out now...

[bsclifton]

@dandart I'm curious- does Brave show you having any saved credentials? I trust that you did save it, but I'm more curious if perhaps an upgrade unintentionally modified that data. Can you can pull up about:passwords to check? Thanks ??

[--- Commented from Asana.com
#commenter brad richter
---[aa]

[danwdart]

Nope - "No passwords have been saved."
Despite me not being given an opportunity to say that I want to save any.

[bsclifton]

@dandart ah ok- so no passwords saved, but you were never given the opportunity to save any in the first place. Did you do any upgrades?

I'm on Ubuntu 16 trying to reproduce this; this is definitely an important bug to fix

[danwdart]

I've done an upgrade from 0.9.x (had to do it manually as the update manager didn't spot it and there is no apt repository).
But since then I think I've cleared my dot files (not certain I restored the old ones).

[bsclifton]

Thanks for helping me understand more of the details- I believe I've found the issue ??

[--- Commented from Asana.com
#commenter brad richter
---[aa]

[danwdart]

Fantastic! If it won't be released for a while, I don't mind running from git.

[bsclifton]

@dandart here is a patch if you wanted to try applying manually 😄
https://github.com/bsclifton/browser-laptop/commit/2a9fee709b407d550fa412375fdb4b1e9ae49d4e

If you get stuck or aren't sure on how to patch, let me know and I'll help get you a new executable with this patch

edit:
SHA was updated because I rebased, but the patch is the same:
30f0f79

[danwdart]

will it work if I just use your branch?

[bsclifton]

@dandart yes- you'll also get some new functionality that's pretty cool too 😄 (about:history page, form auto-fill, and more)

edit:
I made a branch which is 0.11.5 with only this patch too, if you wanted to try that instead:

git clone git@github.com:brave/browser-laptop.git
cd browser-laptop
git remote add bsclifton git@github.com:bsclifton/browser-laptop.git
git fetch bsclifton
git merge bsclifton/patched-0.11.5

[bsclifton]

@dandart the issue is marked as closed, because we did implement a fix... but please let me know how it goes on your end after trying the above 😄

When writing up a test plan, I can get the opposite case happening reliably during an upgrade (having a PW manager set, upgrading, then the built-in prompts show). However, I'm having trouble recreating your scenario

[danwdart]

I haven't been able to verify just yet, as installation of the dev packages wanted me to install gnome-keyring, and even then was still looking for it, maybe I'm missing dev packages. Do you happen to know off hand which dev package I need?

[bsclifton]

@dandart yes- besides having nodejs 6.x, you'll need to run:
apt-get install libgnome-keyring-dev build-essential

I made sure you can build great on Ubuntu 16 w/ just having Node + those packages installed. The npm install should work great 😄

[danwdart]

Thanks - I was about to test but suddenly I've been prompted to save passwords

[bsclifton]

@kathiedart glad it started working again (especially since I could not find a way to reproduce your exact issue; could only break it if you chose 1PW, etc)!

Thanks again for your help finding this issue and helping provide info 😄