Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert vpn change for restore button (uplift to 1.57.x) #19567

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 3, 2023

Uplift of #19514
Resolves brave/brave-browser#31526

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner August 3, 2023 19:38
@brave-builds brave-builds self-assigned this Aug 3, 2023
@brave-builds brave-builds added this to the 1.57.x - Beta milestone Aug 3, 2023
@hffvld
Copy link
Collaborator

hffvld commented Aug 9, 2023

Verified on Pixel 6 and Pixel 7 using version(s):

Device/OS: 
- Pixel 6 [oriole-user 13 TQ3A.230705.001 release-keys]
- Pixel 7 [panther_beta-user 14 UPB4.230623.007 release-keys]
Brave build: 1.58.80
Chromium: 116.0.5845.51 (Official Build) canary (64-bit)
Revision: 4408cc9795df260c5d5f033660ce757782b53b32

STEPS:

  1. Fresh install Brave > Launch it
  2. Set VPN staging server through QA des settings
  3. Three-dot menu > Brave VPN > Observe Restore button
  4. Tap it > Install VPN profile > Verify
  5. Go back to the VPN screen > Purchase subscription > Enable VPN
  6. Uninstall and then reinstall the same Brave build
  7. Enable VPN settings through QA dev settings again
  8. Three-dot menu > Brave VPN > Tap Restore > Install VPN profile > Verify

ACTUAL RESULTS:

  • Verified that Restore button is always appearing via the VPN menu
  • Verified that the user goes through the correct flow if tapped on Restore and there's no current subscription
  • Verified that it restores the VPN subscription if a user has one enabled on Android on multiple devices using Restore

Restore when no active VPN subscription

timestamp_13-59-19_14-00-07.mp4

Restore when active VPN subscription

timestamp_14-03-04_14-04-55.mov

Activating VPN subscription from another device

2023-08-09_14-36-27.mp4

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.57,x approved 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants