Restore button not being displayed when there's an active VPN subscription

[kjozwiak]

Description

After brave/brave-core#18847 landed, the Restore button never appears even though you have an active subscription. Talked to @deeppandya and we'll be reverting brave/brave-core#18847 from 1.57.x and will need a new solution.

Steps to reproduce

1. install 1.55.100 Chromium: 115.0.5790.56 (or any latest Nightly)
2. enable VPN via the QA settings and restart Brave
3. run through the process of getting a subscription and ensure you can connect/use the VPN
4. remove/re-install the same version and enable VPN once again via the QA settings
5. you'll notice there's no Restore button on the VPN opt-in/subscription page
6. click on the same subscription (monthly or yearly) that you did before and notice that it mentions you already have a subscription

Users in this state that have a bought/valid VPN subscription won't be able to restore it.

Actual result

Example	Example

Expected result

The Restore button should be displayed/appearing on new installs if there's an active subscription.

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version? N/A
• Can you reproduce this issue with the current Play Store Beta version? Yes (within 1.57.x)
• Can you reproduce this issue with the current Play Store Nightly version? Yes (within 1.58.x)

Device details

• Install type (ARM, x86): ARM
• Device type (Phone, Tablet, Phablet): Pixel 6 (Phone)
• Android version: Android 14

Brave version

Brave | 1.58.3 Chromium: 115.0.5790.56 (Official Build) canary (64-bit)
--- | ---
Revision | 8faf5df82b5d6598f437ef14482ebcedfe48d5b6
OS | Android 14; Build/UPB3.230519.014; 34; REL

Website problems only

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Additional information

[kjozwiak]

As discussed with @deeppandya and mentioned above, we'll be reverting brave/brave-core#18847 from 1.57.x and will need a new solution. Once we have a new solution, we can uplift into 1.57.x again and discuss uplifting into 1.56.x maintenance release.

[kjozwiak]

The above requires 1.57.44 or higher for 1.57.x verification 👍

[hffvld]

Verified on Galaxy A32 5G and Pixel 7 using version(s):

Device/OS: 
- Galaxy A32 5G [a32xsq-user 13 TP1A.220624.014 release-keys]
- Pixel 7 [panther_beta-user 14 UPB4.230623.007 release-keys]
Brave build: 1.57.44
Chromium: 116.0.5845.82 (Official Build) (64-bit) 
Revision: 109e984111c5152478bf49d266f4e19861c0b63e

---

STEPS:

1. Followed the steps from Restore button not being displayed when there's an active VPN subscription #31526 (comment)

ACTUAL RESULTS:

• Verified that Restore button is always shown on VPN screen
• Verified that the user goes through the correct flow if tapped on Restore and there's no current subscription
• Verified that it restores the VPN subscription if a user has one enabled on Android on multiple devices using Restore

---

Restore button when no active subscription

timestamp_10-28-03_10-28-31.mp4

Restore button when active subscription

Untitled.mp4