Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert vpn change for restore button #19514

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Aug 1, 2023

Resolves brave/brave-browser#31526

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya self-assigned this Aug 1, 2023
@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Aug 1, 2023
@deeppandya deeppandya added this to the 1.58.x - Nightly milestone Aug 1, 2023
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya force-pushed the revert_change_for_vpn branch from da99840 to 3cff0d5 Compare August 3, 2023 02:58
@deeppandya deeppandya force-pushed the revert_change_for_vpn branch from 3cff0d5 to 6f617fa Compare August 3, 2023 17:00
@bsclifton bsclifton enabled auto-merge August 3, 2023 19:05
@bsclifton bsclifton merged commit 7fc2cb8 into master Aug 3, 2023
@bsclifton bsclifton deleted the revert_change_for_vpn branch August 3, 2023 19:33
brave-builds added a commit that referenced this pull request Aug 3, 2023
@kjozwiak
Copy link
Member

The above was verified by QA on Nightly via #19567 (comment).

kjozwiak pushed a commit that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore button not being displayed when there's an active VPN subscription
4 participants