Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ChromePreferenceKeyChecker to avoid crashes on Nightly #17431

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Mar 1, 2023

Resolves brave/brave-browser#28831

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

I could not get the exact STR for that crash stack, so the test plan is quite general:

  1. Take official Nightly build, because on Stable/Beta/Non-official builds the original issue is not reproducible;
  2. Install application;
  3. Open menu=>settings to trigger some prefs reading;
  4. Add Any Nightly widget to the home screen (as the original crash has calls with widget involved);
    Expected not to have crash.

@AlexeyBarabash AlexeyBarabash force-pushed the android_keychecker_crash branch from 975a451 to 41b9ab0 Compare March 1, 2023 18:21
@AlexeyBarabash AlexeyBarabash added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 1, 2023
@AlexeyBarabash AlexeyBarabash marked this pull request as ready for review March 1, 2023 21:37
@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner March 1, 2023 21:37
@AlexeyBarabash AlexeyBarabash force-pushed the android_keychecker_crash branch from 41b9ab0 to 340defc Compare March 1, 2023 21:38
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexeyBarabash AlexeyBarabash force-pushed the android_keychecker_crash branch from 340defc to dbe3003 Compare March 2, 2023 12:26
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@AlexeyBarabash AlexeyBarabash merged commit 1073aee into master Mar 2, 2023
@AlexeyBarabash AlexeyBarabash deleted the android_keychecker_crash branch March 2, 2023 14:55
@AlexeyBarabash AlexeyBarabash added this to the 1.51.x - Nightly milestone Mar 2, 2023
AlexeyBarabash added a commit that referenced this pull request Mar 2, 2023
AlexeyBarabash added a commit that referenced this pull request Mar 2, 2023
Revert "Merge pull request #17431 from brave/android_keychecker_crash"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash at ChromePreferenceKeyChecker
4 participants