Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert PR brave/brave-core#17431 #28863

Closed
AlexeyBarabash opened this issue Mar 2, 2023 · 0 comments · Fixed by brave/brave-core#17451
Closed

Revert PR brave/brave-core#17431 #28863

AlexeyBarabash opened this issue Mar 2, 2023 · 0 comments · Fixed by brave/brave-core#17451
Assignees
@AlexeyBarabash
Labels
build dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Milestone
1.51.x - Release

Comments

@AlexeyBarabash
Copy link
Contributor

PR brave/brave-core#17431 breaks Release x86 aab build.

Command:

npm run create_dist -- Release --channel=nightly --target_os=android --target_arch=x86 --target_android_base=mono --target_android_output_format=aab

Error:

19:17:52  Warning: Missing class bA (referenced from: void org.chromium.chrome.browser.preferences.SharedPreferencesManager.d())
19:17:52  Missing method void bA.a() (referenced from: void org.chromium.chrome.browser.preferences.SharedPreferencesManager.d())

Must be reverted and re-landed after fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
build dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Revert "Merge pull request #17431 from brave/android_keychecker_crash" brave/brave-core
2 participants
@AlexeyBarabash @brave-builds