Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland again brave/brave-core/pull/17431 #28978

Closed
AlexeyBarabash opened this issue Mar 9, 2023 · 2 comments · Fixed by brave/brave-core#17545
Closed

Reland again brave/brave-core/pull/17431 #28978

AlexeyBarabash opened this issue Mar 9, 2023 · 2 comments · Fixed by brave/brave-core#17545
Assignees
@AlexeyBarabash
Labels
dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Milestone
1.51.x - Release

Comments

@AlexeyBarabash
Copy link
Contributor

PR brave/brave-core/pull/17431 was reverted twice:

Original issue: #28831
Original PR: brave/brave-core#17431

Test plan:

  1. Ensure Stable channel Release build is not broken:
    npm run build -- Release --target_arch=x86 --target_android_base=mono --target_os=android --target_android_output_format=apk;
  2. Ensure there is no crash on app start and possible to pass onboarding.
@AlexeyBarabash AlexeyBarabash added QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Mar 9, 2023
@AlexeyBarabash AlexeyBarabash self-assigned this Mar 9, 2023
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Mar 9, 2023
@AlexeyBarabash
Reland again Disable ChromePreferenceKeyChecker to avoid crashes on N…
4cbb87a 
…ightly

Fixes brave/brave-browser#28978
@AlexeyBarabash AlexeyBarabash mentioned this issue Mar 9, 2023
Merged
25 tasks
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Mar 10, 2023
@AlexeyBarabash
Reland again Disable ChromePreferenceKeyChecker to avoid crashes on N…
19adf7f 
…ightly

Fixes brave/brave-browser#28978
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 10, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Apr 6, 2023

As per brave/brave-core#17545 (comment), the QA will basically run through the STR/Cases every time we install the app while running through 1.51.x verifications. So this will get verified several times by default. Labelling as QA/No.

@AlexeyBarabash
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Reland again android keychecker crash brave/brave-core
3 participants
@kjozwiak @AlexeyBarabash @brave-builds