feat(wallet): implement ramp network support #16558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -967,12 +970,11 @@ public void onTextChanged(CharSequence s, int start, int before, int count) { | |||
| setSendToFromValueValidationResult(errorMessage, false, true); | |||
| }); | |||
| } | |||
| } else if (mActivityType == ActivityType.BUY | |||
| && mSelectedNetwork.chainId.equals(BraveWalletConstants.MAINNET_CHAIN_ID)) { | |||
| } else if (mActivityType == ActivityType.BUY) { | |||
There was a problem hiding this comment.
do we support buy on all networks including test nets? maybe we should exclude test chains in that place?
There was a problem hiding this comment.
or it just gives an error Could not get buy URL in that case and we are ok?
There was a problem hiding this comment.
Those are excluded here with allowBuy so the buy option is hidden for excluded networks.
BTW, in future, with more providers, we will have to show a message "buy not supported" based on the result of token list.
There was a problem hiding this comment.
Demo of excluded networks
ramp-excluded-networks.webm
- Remove wyre
0764b44 to
9d6ee8a
Compare
Pavneet-Sing
pushed a commit
that referenced
this pull request
Jan 10, 2023
7 tasks
7 tasks
Pavneet-Sing
pushed a commit
that referenced
this pull request
Jan 10, 2023
|
Verification passed on Lenovo Tab with Android 12 running 1.49.36 x64 Nightly build
16558.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#27678
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
android-ramp-support.webm
Additional Info