Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ramp network support and remove wyre #27678

Closed
Pavneet-Sing opened this issue Jan 6, 2023 · 2 comments · Fixed by brave/brave-core#16558
Closed

Add Ramp network support and remove wyre #27678

Pavneet-Sing opened this issue Jan 6, 2023 · 2 comments · Fixed by brave/brave-core#16558
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.47.x - Release #4

Comments

@Pavneet-Sing
Copy link

Description

Add Ramp network support to buy assets and remove wyre option from buy
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 6, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Jan 6, 2023
@Pavneet-Sing Pavneet-Sing added this to Web3 Jan 6, 2023
@Pavneet-Sing Pavneet-Sing moved this to In Review in Web3 Jan 6, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Jan 6, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 10, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 10, 2023
This was referenced Jan 10, 2023
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.47.176 or higher for 1.47.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.47.177 x64 build

  • Verified steps from brave/brave-core#16558
  • Verified selecting Buy in the quick action shows Continue to Ramp
  • Verified clicking on Continue to Ramp loads the on-ramp page with the selected token prefilled
  • Verified if no amount is entered a default value is pre-populated on the on-ramp page
  • Verified selecting a token and clicking on Buy button shows Continue to Ramp to proceed to purchase
  • Verified able to select address in dropdown to change the deposit address on the on-ramp page
  • Verified on the on-ramp page can't change the token for which it is pre-populated
Oppo Reno 5 (Android 12) Lenovo Tab (Android 12)
27678-ARM.mp4
27678-Tab.mp4

This was referenced Jan 25, 2023
Closed
Closed
@Pavneet-Sing Pavneet-Sing mentioned this issue Feb 7, 2023
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.47.x - Release #4
Development

Successfully merging a pull request may close this issue.

feat(wallet): implement ramp network support brave/brave-core
4 participants
@kjozwiak @Pavneet-Sing @srirambv @brave-builds